From 962461331ea8907a0ea5d01659311a1fe20968ad Mon Sep 17 00:00:00 2001 From: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Date: Tue, 24 Sep 2024 15:55:46 -0700 Subject: [PATCH 01/10] first pass --- docs/data/charts/bars/BorderRadius.js | 2 +- docs/data/charts/bars/BorderRadius.tsx | 2 +- .../server-side-data/ServerSideErrorHandling.js | 2 +- .../server-side-data/ServerSideErrorHandling.tsx | 2 +- .../ServerSideTreeDataErrorHandling.js | 6 +++--- .../ServerSideTreeDataErrorHandling.tsx | 6 +++--- .../modules/components/CustomizationPlayground.tsx | 2 +- .../components/overview/Internationalization.tsx | 2 +- docs/src/modules/components/overview/Keyboard.tsx | 2 +- docs/src/modules/components/overview/WorldMapSvg.tsx | 12 ++++++------ .../src/context/ZoomProvider/useSetupPan.ts | 4 ++-- .../src/context/ZoomProvider/useSetupZoom.ts | 2 +- .../src/ChartsLegend/DefaultChartsLegend.tsx | 2 +- packages/x-charts/src/ChartsLegend/LegendPerItem.tsx | 2 +- .../src/ChartsLegend/PiecewiseColorLegend.tsx | 2 +- packages/x-charts/src/hooks/useReducedMotion.ts | 4 ++-- packages/x-charts/src/internals/domUtils.ts | 2 +- .../x-data-grid-generator/src/hooks/useMockServer.ts | 2 +- .../features/aggregation/gridAggregationUtils.ts | 2 +- .../hooks/features/dataSource/useGridDataSource.ts | 6 +++--- .../x-data-grid/src/components/cell/GridCell.tsx | 6 +++--- packages/x-data-grid/src/utils/createSelector.ts | 6 ++++++ .../src/AdapterDateFnsBase/AdapterDateFnsBase.ts | 1 + .../src/AdapterMoment/AdapterMoment.ts | 1 + .../describeGregorianAdapter.ts | 2 +- 25 files changed, 45 insertions(+), 37 deletions(-) diff --git a/docs/data/charts/bars/BorderRadius.js b/docs/data/charts/bars/BorderRadius.js index 03864320f950..824c7f55ff37 100644 --- a/docs/data/charts/bars/BorderRadius.js +++ b/docs/data/charts/bars/BorderRadius.js @@ -19,7 +19,7 @@ export default function BorderRadius() { Border Radius setRadius(v)} + onChange={(event, value) => setRadius(value)} valueLabelDisplay="auto" min={0} max={50} diff --git a/docs/data/charts/bars/BorderRadius.tsx b/docs/data/charts/bars/BorderRadius.tsx index e1b72ab6feac..f08f1bde8194 100644 --- a/docs/data/charts/bars/BorderRadius.tsx +++ b/docs/data/charts/bars/BorderRadius.tsx @@ -19,7 +19,7 @@ export default function BorderRadius() { Border Radius setRadius(v as number)} + onChange={(event, value) => setRadius(value as number)} valueLabelDisplay="auto" min={0} max={50} diff --git a/docs/data/data-grid/server-side-data/ServerSideErrorHandling.js b/docs/data/data-grid/server-side-data/ServerSideErrorHandling.js index 75fd9a5422ac..c6e12528f0f4 100644 --- a/docs/data/data-grid/server-side-data/ServerSideErrorHandling.js +++ b/docs/data/data-grid/server-side-data/ServerSideErrorHandling.js @@ -104,7 +104,7 @@ export default function ServerSideErrorHandling() { setError(e.message)} + unstable_onDataSourceError={(err) => setError(err.message)} unstable_dataSourceCache={null} apiRef={apiRef} pagination diff --git a/docs/data/data-grid/server-side-data/ServerSideErrorHandling.tsx b/docs/data/data-grid/server-side-data/ServerSideErrorHandling.tsx index 2ea04e50c57f..5d1aa472b987 100644 --- a/docs/data/data-grid/server-side-data/ServerSideErrorHandling.tsx +++ b/docs/data/data-grid/server-side-data/ServerSideErrorHandling.tsx @@ -110,7 +110,7 @@ export default function ServerSideErrorHandling() { setError(e.message)} + unstable_onDataSourceError={(err) => setError(err.message)} unstable_dataSourceCache={null} apiRef={apiRef} pagination diff --git a/docs/data/data-grid/server-side-data/ServerSideTreeDataErrorHandling.js b/docs/data/data-grid/server-side-data/ServerSideTreeDataErrorHandling.js index 1066e54daf35..1b93b99e8ebf 100644 --- a/docs/data/data-grid/server-side-data/ServerSideTreeDataErrorHandling.js +++ b/docs/data/data-grid/server-side-data/ServerSideTreeDataErrorHandling.js @@ -89,12 +89,12 @@ export default function ServerSideTreeDataErrorHandling() { {...props} treeData unstable_dataSource={dataSource} - unstable_onDataSourceError={(e, params) => { + unstable_onDataSourceError={(error, params) => { if (!params.groupKeys || params.groupKeys.length === 0) { - setRootError(e.message); + setRootError(error.message); } else { setChildrenError( - `${e.message} (Requested level: ${params.groupKeys.join(' > ')})`, + `${error.message} (Requested level: ${params.groupKeys.join(' > ')})`, ); } }} diff --git a/docs/data/data-grid/server-side-data/ServerSideTreeDataErrorHandling.tsx b/docs/data/data-grid/server-side-data/ServerSideTreeDataErrorHandling.tsx index c62baec1a6a7..a4662f30ac3a 100644 --- a/docs/data/data-grid/server-side-data/ServerSideTreeDataErrorHandling.tsx +++ b/docs/data/data-grid/server-side-data/ServerSideTreeDataErrorHandling.tsx @@ -94,12 +94,12 @@ export default function ServerSideTreeDataErrorHandling() { {...props} treeData unstable_dataSource={dataSource} - unstable_onDataSourceError={(e, params) => { + unstable_onDataSourceError={(error, params) => { if (!params.groupKeys || params.groupKeys.length === 0) { - setRootError(e.message); + setRootError(error.message); } else { setChildrenError( - `${e.message} (Requested level: ${params.groupKeys.join(' > ')})`, + `${error.message} (Requested level: ${params.groupKeys.join(' > ')})`, ); } }} diff --git a/docs/src/modules/components/CustomizationPlayground.tsx b/docs/src/modules/components/CustomizationPlayground.tsx index 64aaa0e48bec..8f82c2c0dc30 100644 --- a/docs/src/modules/components/CustomizationPlayground.tsx +++ b/docs/src/modules/components/CustomizationPlayground.tsx @@ -134,7 +134,7 @@ const StyledTabs = styled(Tabs)(({ theme }) => ({ type TabsProps = { value: string; - onChange: (e: React.SyntheticEvent, value: any) => void; + onChange: (event: React.SyntheticEvent, value: any) => void; options: Partial; }; diff --git a/docs/src/modules/components/overview/Internationalization.tsx b/docs/src/modules/components/overview/Internationalization.tsx index b0f898001d8a..bfdb81a42f66 100644 --- a/docs/src/modules/components/overview/Internationalization.tsx +++ b/docs/src/modules/components/overview/Internationalization.tsx @@ -102,7 +102,7 @@ function TimezonesDemo() { const brandingTheme = useTheme(); const theme = createTheme({ palette: { mode: brandingTheme.palette.mode } }); - const handleContinentClick: ContinentClickHandler = (e, newTimezone) => { + const handleContinentClick: ContinentClickHandler = (event, newTimezone) => { if (selectedTimezone === newTimezone) { setSelectedTimezone(null); } else { diff --git a/docs/src/modules/components/overview/Keyboard.tsx b/docs/src/modules/components/overview/Keyboard.tsx index 456604d975c9..3e20b7819676 100644 --- a/docs/src/modules/components/overview/Keyboard.tsx +++ b/docs/src/modules/components/overview/Keyboard.tsx @@ -410,7 +410,7 @@ export default function Keyboard() { const brandingTheme = useTheme(); const theme = createTheme({ palette: { mode: brandingTheme.palette.mode } }); - const handleKeySelection = (e: React.SyntheticEvent, key: SelectedKey | null) => { + const handleKeySelection = (ev: React.SyntheticEvent, key: SelectedKey | null) => { const sectionContent = (ref.current as any).querySelector( `.MuiPickersSectionList-section[data-sectionindex="${selectedSection.current || 0}"] .MuiPickersSectionList-sectionContent`, ); diff --git a/docs/src/modules/components/overview/WorldMapSvg.tsx b/docs/src/modules/components/overview/WorldMapSvg.tsx index 9818f694d745..aef3641d92f3 100644 --- a/docs/src/modules/components/overview/WorldMapSvg.tsx +++ b/docs/src/modules/components/overview/WorldMapSvg.tsx @@ -41,7 +41,7 @@ export default function WorldMapSvg({ onClickContinent, selectedTimezone }: Worl onClickContinent(e, timezones.northAmerica)} + onClick={(event) => onClickContinent(event, timezones.northAmerica)} > @@ -56,14 +56,14 @@ export default function WorldMapSvg({ onClickContinent, selectedTimezone }: Worl onClickContinent(e, timezones.southAmerica)} + onClick={(event) => onClickContinent(event, timezones.southAmerica)} > onClickContinent(e, timezones.europe)} + onClick={(event) => onClickContinent(event, timezones.europe)} > @@ -80,7 +80,7 @@ export default function WorldMapSvg({ onClickContinent, selectedTimezone }: Worl onClickContinent(e, timezones.asia)} + onClick={(event) => onClickContinent(event, timezones.asia)} > @@ -104,7 +104,7 @@ export default function WorldMapSvg({ onClickContinent, selectedTimezone }: Worl onClickContinent(e, timezones.africa)} + onClick={(event) => onClickContinent(event, timezones.africa)} > @@ -112,7 +112,7 @@ export default function WorldMapSvg({ onClickContinent, selectedTimezone }: Worl onClickContinent(e, timezones.australia)} + onClick={(event) => onClickContinent(event, timezones.australia)} > diff --git a/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts b/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts index 98b89fe73a3b..0545b61acd30 100644 --- a/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts +++ b/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts @@ -104,9 +104,9 @@ export const useSetupPan = () => { }; }; - const handleUp = (event: PointerEvent) => { + const handleUp = () => { eventCacheRef.current.splice( - eventCacheRef.current.findIndex((e) => e.pointerId === event.pointerId), + eventCacheRef.current.findIndex((event) => event.pointerId), 1, ); setIsInteracting(false); diff --git a/packages/x-charts-pro/src/context/ZoomProvider/useSetupZoom.ts b/packages/x-charts-pro/src/context/ZoomProvider/useSetupZoom.ts index 6410372fc74b..0757e0439db3 100644 --- a/packages/x-charts-pro/src/context/ZoomProvider/useSetupZoom.ts +++ b/packages/x-charts-pro/src/context/ZoomProvider/useSetupZoom.ts @@ -178,7 +178,7 @@ export const useSetupZoom = () => { function pointerUpHandler(event: PointerEvent) { eventCacheRef.current.splice( - eventCacheRef.current.findIndex((e) => e.pointerId === event.pointerId), + eventCacheRef.current.findIndex((upEvent) => upEvent.pointerId), 1, ); diff --git a/packages/x-charts/src/ChartsLegend/DefaultChartsLegend.tsx b/packages/x-charts/src/ChartsLegend/DefaultChartsLegend.tsx index e161bdb9a4f2..7278a105536f 100644 --- a/packages/x-charts/src/ChartsLegend/DefaultChartsLegend.tsx +++ b/packages/x-charts/src/ChartsLegend/DefaultChartsLegend.tsx @@ -54,7 +54,7 @@ function DefaultChartsLegend(props: LegendRendererProps) { itemsToDisplay={seriesToDisplay} onItemClick={ onItemClick - ? (e, i) => onItemClick(e, seriesContextBuilder(seriesToDisplay[i]), i) + ? (event, i) => onItemClick(event, seriesContextBuilder(seriesToDisplay[i]), i) : undefined } /> diff --git a/packages/x-charts/src/ChartsLegend/LegendPerItem.tsx b/packages/x-charts/src/ChartsLegend/LegendPerItem.tsx index 6edd54deb32a..60abf0ff950d 100644 --- a/packages/x-charts/src/ChartsLegend/LegendPerItem.tsx +++ b/packages/x-charts/src/ChartsLegend/LegendPerItem.tsx @@ -206,7 +206,7 @@ export function LegendPerItem(props: LegendPerItemProps) { markGap={markGap} labelStyle={labelStyle} classes={classes} - onClick={onItemClick ? (e) => onItemClick(e, i) : undefined} + onClick={onItemClick ? (event) => onItemClick(event, i) : undefined} /> ))} diff --git a/packages/x-charts/src/ChartsLegend/PiecewiseColorLegend.tsx b/packages/x-charts/src/ChartsLegend/PiecewiseColorLegend.tsx index f7df59c36952..fa94832fc4d3 100644 --- a/packages/x-charts/src/ChartsLegend/PiecewiseColorLegend.tsx +++ b/packages/x-charts/src/ChartsLegend/PiecewiseColorLegend.tsx @@ -121,7 +121,7 @@ function PiecewiseColorLegend(props: PiecewiseColorLegendProps) { itemsToDisplay={itemsToDisplay} onItemClick={ onItemClick - ? (e, i) => onItemClick(e, piecewiseColorContextBuilder(itemsToDisplay[i]), i) + ? (event, i) => onItemClick(event, piecewiseColorContextBuilder(itemsToDisplay[i]), i) : undefined } /> diff --git a/packages/x-charts/src/hooks/useReducedMotion.ts b/packages/x-charts/src/hooks/useReducedMotion.ts index 5acafab44e80..cda035597e46 100644 --- a/packages/x-charts/src/hooks/useReducedMotion.ts +++ b/packages/x-charts/src/hooks/useReducedMotion.ts @@ -1,10 +1,10 @@ 'use client'; import { useIsomorphicLayoutEffect, Globals } from '@react-spring/web'; -const handleMediaChange = (e: { matches: boolean | undefined }) => { +const handleMediaChange = (event: { matches: boolean | undefined }) => { Globals.assign({ // Modification such the react-spring implementation such that this hook can remove animation but never activate animation. - skipAnimation: e.matches || undefined, + skipAnimation: event.matches || undefined, }); }; diff --git a/packages/x-charts/src/internals/domUtils.ts b/packages/x-charts/src/internals/domUtils.ts index e8a1b2e2d119..eccb61fb69ff 100644 --- a/packages/x-charts/src/internals/domUtils.ts +++ b/packages/x-charts/src/internals/domUtils.ts @@ -156,7 +156,7 @@ export const getStringSize = (text: string | number, style: React.CSSProperties }, 0); return result; - } catch (e) { + } catch { return { width: 0, height: 0 }; } }; diff --git a/packages/x-data-grid-generator/src/hooks/useMockServer.ts b/packages/x-data-grid-generator/src/hooks/useMockServer.ts index 7f16fc41c647..83c43fd30c05 100644 --- a/packages/x-data-grid-generator/src/hooks/useMockServer.ts +++ b/packages/x-data-grid-generator/src/hooks/useMockServer.ts @@ -51,7 +51,7 @@ function decodeParams(url: string): GridGetRowsParams { for (const [key, value] of array) { try { decodedParams[key] = JSON.parse(value); - } catch (e) { + } catch { decodedParams[key] = value; } } diff --git a/packages/x-data-grid-premium/src/hooks/features/aggregation/gridAggregationUtils.ts b/packages/x-data-grid-premium/src/hooks/features/aggregation/gridAggregationUtils.ts index b826d8f0d7d5..0f15aa74136b 100644 --- a/packages/x-data-grid-premium/src/hooks/features/aggregation/gridAggregationUtils.ts +++ b/packages/x-data-grid-premium/src/hooks/features/aggregation/gridAggregationUtils.ts @@ -261,7 +261,7 @@ export const getAggregationFunctionLabel = ({ aggregationRule.aggregationFunctionName, )}` as 'aggregationFunctionLabelSum', ); - } catch (e) { + } catch { return aggregationRule.aggregationFunctionName; } }; diff --git a/packages/x-data-grid-pro/src/hooks/features/dataSource/useGridDataSource.ts b/packages/x-data-grid-pro/src/hooks/features/dataSource/useGridDataSource.ts index b948c0a48745..3746a036a1ed 100644 --- a/packages/x-data-grid-pro/src/hooks/features/dataSource/useGridDataSource.ts +++ b/packages/x-data-grid-pro/src/hooks/features/dataSource/useGridDataSource.ts @@ -178,9 +178,9 @@ export const useGridDataSource = ( apiRef.current.updateServerRows(getRowsResponse.rows, rowNode.path); apiRef.current.setRowChildrenExpansion(id, true); } catch (error) { - const e = error as Error; - apiRef.current.unstable_dataSource.setChildrenFetchError(id, e); - onError?.(e, fetchParams); + const err = error as Error; + apiRef.current.unstable_dataSource.setChildrenFetchError(id, err); + onError?.(err, fetchParams); } finally { apiRef.current.unstable_dataSource.setChildrenLoading(id, false); nestedDataManager.setRequestSettled(id); diff --git a/packages/x-data-grid/src/components/cell/GridCell.tsx b/packages/x-data-grid/src/components/cell/GridCell.tsx index c742def4102e..acd333d9c5b2 100644 --- a/packages/x-data-grid/src/components/cell/GridCell.tsx +++ b/packages/x-data-grid/src/components/cell/GridCell.tsx @@ -197,11 +197,11 @@ const GridCell = React.forwardRef(function GridCe ); result.api = apiRef.current; return result; - } catch (e) { - if (e instanceof MissingRowIdError) { + } catch (error) { + if (error instanceof MissingRowIdError) { return EMPTY_CELL_PARAMS; } - throw e; + throw error; } }, objectShallowCompare, diff --git a/packages/x-data-grid/src/utils/createSelector.ts b/packages/x-data-grid/src/utils/createSelector.ts index 965b07ed5c2b..61f343783780 100644 --- a/packages/x-data-grid/src/utils/createSelector.ts +++ b/packages/x-data-grid/src/utils/createSelector.ts @@ -91,6 +91,7 @@ export const createSelector = (( b: Function, c?: Function, d?: Function, + // eslint-disable-next-line id-denylist e?: Function, f?: Function, ...other: any[] @@ -101,6 +102,7 @@ export const createSelector = (( let selector: any; + // eslint-disable-next-line id-denylist if (a && b && c && d && e && f) { selector = (stateOrApiRef: any, instanceIdParam: any) => { const isAPIRef = checkIsAPIRef(stateOrApiRef); @@ -114,6 +116,7 @@ export const createSelector = (( const ve = e(state, instanceId); return f(va, vb, vc, vd, ve); }; + // eslint-disable-next-line id-denylist } else if (a && b && c && d && e) { selector = (stateOrApiRef: any, instanceIdParam: any) => { const isAPIRef = checkIsAPIRef(stateOrApiRef); @@ -173,6 +176,7 @@ export const createSelectorV8 = (( b: Function, c?: Function, d?: Function, + // eslint-disable-next-line id-denylist e?: Function, f?: Function, ...other: any[] @@ -183,6 +187,7 @@ export const createSelectorV8 = (( let selector: any; + // eslint-disable-next-line id-denylist if (a && b && c && d && e && f) { selector = (stateOrApiRef: any, args: any, instanceIdParam: any) => { const isAPIRef = checkIsAPIRef(stateOrApiRef); @@ -196,6 +201,7 @@ export const createSelectorV8 = (( const ve = e(state, args, instanceId); return f(va, vb, vc, vd, ve, args); }; + // eslint-disable-next-line id-denylist } else if (a && b && c && d && e) { selector = (stateOrApiRef: any, args: any, instanceIdParam: any) => { const isAPIRef = checkIsAPIRef(stateOrApiRef); diff --git a/packages/x-date-pickers/src/AdapterDateFnsBase/AdapterDateFnsBase.ts b/packages/x-date-pickers/src/AdapterDateFnsBase/AdapterDateFnsBase.ts index 32f9f873d0aa..4001a00d973c 100644 --- a/packages/x-date-pickers/src/AdapterDateFnsBase/AdapterDateFnsBase.ts +++ b/packages/x-date-pickers/src/AdapterDateFnsBase/AdapterDateFnsBase.ts @@ -49,6 +49,7 @@ const formatTokenMap: FieldFormatTokenMap = { ii: 'weekDay', iii: { sectionType: 'weekDay', contentType: 'letter' }, iiii: { sectionType: 'weekDay', contentType: 'letter' }, + // eslint-disable-next-line id-denylist e: { sectionType: 'weekDay', contentType: 'digit', maxLength: 1 }, ee: 'weekDay', eee: { sectionType: 'weekDay', contentType: 'letter' }, diff --git a/packages/x-date-pickers/src/AdapterMoment/AdapterMoment.ts b/packages/x-date-pickers/src/AdapterMoment/AdapterMoment.ts index a6e5288f2ed9..426d0404f487 100644 --- a/packages/x-date-pickers/src/AdapterMoment/AdapterMoment.ts +++ b/packages/x-date-pickers/src/AdapterMoment/AdapterMoment.ts @@ -29,6 +29,7 @@ const formatTokenMap: FieldFormatTokenMap = { // Day of the week E: { sectionType: 'weekDay', contentType: 'digit', maxLength: 1 }, + // eslint-disable-next-line id-denylist e: { sectionType: 'weekDay', contentType: 'digit', maxLength: 1 }, d: { sectionType: 'weekDay', contentType: 'digit', maxLength: 1 }, dd: { sectionType: 'weekDay', contentType: 'letter' }, diff --git a/test/utils/pickers/describeGregorianAdapter/describeGregorianAdapter.ts b/test/utils/pickers/describeGregorianAdapter/describeGregorianAdapter.ts index be64e37fa3af..34f25e5207cc 100644 --- a/test/utils/pickers/describeGregorianAdapter/describeGregorianAdapter.ts +++ b/test/utils/pickers/describeGregorianAdapter/describeGregorianAdapter.ts @@ -12,7 +12,7 @@ function innerGregorianDescribeAdapter( Adapter: new (...args: any) => MuiPickersAdapter, params: DescribeGregorianAdapterParams, ) { - const prepareAdapter = params.prepareAdapter ?? ((e) => e); + const prepareAdapter = params.prepareAdapter ?? ((event) => event); const adapter = new Adapter(); const adapterTZ = params.dateLibInstanceWithTimezoneSupport From 36edaffa18b1654973568cbfc6bc83a50c99615d Mon Sep 17 00:00:00 2001 From: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Date: Wed, 25 Sep 2024 09:52:36 -0700 Subject: [PATCH 02/10] jan and jose reviews --- .../server-side-data/ServerSideErrorHandling.js | 2 +- .../server-side-data/ServerSideErrorHandling.tsx | 2 +- docs/src/modules/components/overview/Keyboard.tsx | 6 +++--- .../src/context/ZoomProvider/useSetupPan.ts | 12 ++++++------ .../src/context/ZoomProvider/useSetupZoom.ts | 2 +- .../describeGregorianAdapter.ts | 2 +- 6 files changed, 13 insertions(+), 13 deletions(-) diff --git a/docs/data/data-grid/server-side-data/ServerSideErrorHandling.js b/docs/data/data-grid/server-side-data/ServerSideErrorHandling.js index c6e12528f0f4..6ea73b483a93 100644 --- a/docs/data/data-grid/server-side-data/ServerSideErrorHandling.js +++ b/docs/data/data-grid/server-side-data/ServerSideErrorHandling.js @@ -104,7 +104,7 @@ export default function ServerSideErrorHandling() { setError(err.message)} + unstable_onDataSourceError={(dataSourceError) => setError(dataSourceError.message)} unstable_dataSourceCache={null} apiRef={apiRef} pagination diff --git a/docs/data/data-grid/server-side-data/ServerSideErrorHandling.tsx b/docs/data/data-grid/server-side-data/ServerSideErrorHandling.tsx index 5d1aa472b987..dce535cb5c30 100644 --- a/docs/data/data-grid/server-side-data/ServerSideErrorHandling.tsx +++ b/docs/data/data-grid/server-side-data/ServerSideErrorHandling.tsx @@ -110,7 +110,7 @@ export default function ServerSideErrorHandling() { setError(err.message)} + unstable_onDataSourceError={(dataSourceError) => setError(dataSourceError.message)} unstable_dataSourceCache={null} apiRef={apiRef} pagination diff --git a/docs/src/modules/components/overview/Keyboard.tsx b/docs/src/modules/components/overview/Keyboard.tsx index 3e20b7819676..0d5b65785587 100644 --- a/docs/src/modules/components/overview/Keyboard.tsx +++ b/docs/src/modules/components/overview/Keyboard.tsx @@ -410,20 +410,20 @@ export default function Keyboard() { const brandingTheme = useTheme(); const theme = createTheme({ palette: { mode: brandingTheme.palette.mode } }); - const handleKeySelection = (ev: React.SyntheticEvent, key: SelectedKey | null) => { + const handleKeySelection = (event: React.SyntheticEvent, key: SelectedKey | null) => { const sectionContent = (ref.current as any).querySelector( `.MuiPickersSectionList-section[data-sectionindex="${selectedSection.current || 0}"] .MuiPickersSectionList-sectionContent`, ); sectionContent.focus(); if (key) { - const event = new KeyboardEvent('keydown', { + const dispatchedEvent = new KeyboardEvent('keydown', { ...key, bubbles: true, cancelable: true, }); - sectionContent.dispatchEvent(event); + sectionContent.dispatchEvent(dispatchedEvent); if (key.key === 'Backspace') { sectionContent.textContent = ''; diff --git a/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts b/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts index 0545b61acd30..4569d62ff81d 100644 --- a/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts +++ b/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts @@ -81,9 +81,9 @@ export const useSetupPan = () => { setZoomData(newZoomData); }; - const handleDown = (event: PointerEvent) => { - eventCacheRef.current.push(event); - const point = getSVGPoint(element, event); + const handleDown = (downEvent: PointerEvent) => { + eventCacheRef.current.push(downEvent); + const point = getSVGPoint(element, downEvent); if (!drawingArea.isPointInside(point)) { return; @@ -91,7 +91,7 @@ export const useSetupPan = () => { // If there is only one pointer, prevent selecting text if (eventCacheRef.current.length === 1) { - event.preventDefault(); + downEvent.preventDefault(); } isDraggingRef.current = true; @@ -104,9 +104,9 @@ export const useSetupPan = () => { }; }; - const handleUp = () => { + const handleUp = (upEvent: PointerEvent) => { eventCacheRef.current.splice( - eventCacheRef.current.findIndex((event) => event.pointerId), + eventCacheRef.current.findIndex((eventIndex) => eventIndex.pointerId === upEvent.pointerId), 1, ); setIsInteracting(false); diff --git a/packages/x-charts-pro/src/context/ZoomProvider/useSetupZoom.ts b/packages/x-charts-pro/src/context/ZoomProvider/useSetupZoom.ts index 0757e0439db3..e2c9cb1453a1 100644 --- a/packages/x-charts-pro/src/context/ZoomProvider/useSetupZoom.ts +++ b/packages/x-charts-pro/src/context/ZoomProvider/useSetupZoom.ts @@ -178,7 +178,7 @@ export const useSetupZoom = () => { function pointerUpHandler(event: PointerEvent) { eventCacheRef.current.splice( - eventCacheRef.current.findIndex((upEvent) => upEvent.pointerId), + eventCacheRef.current.findIndex((eventIndex) => eventIndex.pointerId === event.pointerId), 1, ); diff --git a/test/utils/pickers/describeGregorianAdapter/describeGregorianAdapter.ts b/test/utils/pickers/describeGregorianAdapter/describeGregorianAdapter.ts index 34f25e5207cc..9b457d082181 100644 --- a/test/utils/pickers/describeGregorianAdapter/describeGregorianAdapter.ts +++ b/test/utils/pickers/describeGregorianAdapter/describeGregorianAdapter.ts @@ -12,7 +12,7 @@ function innerGregorianDescribeAdapter( Adapter: new (...args: any) => MuiPickersAdapter, params: DescribeGregorianAdapterParams, ) { - const prepareAdapter = params.prepareAdapter ?? ((event) => event); + const prepareAdapter = params.prepareAdapter ?? ((adapter) => adapter); const adapter = new Adapter(); const adapterTZ = params.dateLibInstanceWithTimezoneSupport From 3db7d25d813d171d928e78783d7ddb68adf6da8e Mon Sep 17 00:00:00 2001 From: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Date: Wed, 25 Sep 2024 10:01:26 -0700 Subject: [PATCH 03/10] err -> childrenFetchError --- .../src/hooks/features/dataSource/useGridDataSource.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/x-data-grid-pro/src/hooks/features/dataSource/useGridDataSource.ts b/packages/x-data-grid-pro/src/hooks/features/dataSource/useGridDataSource.ts index 3746a036a1ed..4e365d10d7ee 100644 --- a/packages/x-data-grid-pro/src/hooks/features/dataSource/useGridDataSource.ts +++ b/packages/x-data-grid-pro/src/hooks/features/dataSource/useGridDataSource.ts @@ -178,9 +178,9 @@ export const useGridDataSource = ( apiRef.current.updateServerRows(getRowsResponse.rows, rowNode.path); apiRef.current.setRowChildrenExpansion(id, true); } catch (error) { - const err = error as Error; - apiRef.current.unstable_dataSource.setChildrenFetchError(id, err); - onError?.(err, fetchParams); + const childrenFetchError = error as Error; + apiRef.current.unstable_dataSource.setChildrenFetchError(id, childrenFetchError); + onError?.(childrenFetchError, fetchParams); } finally { apiRef.current.unstable_dataSource.setChildrenLoading(id, false); nestedDataManager.setRequestSettled(id); From 7cc27d403254dc287551693ffe15874d3e63cd2b Mon Sep 17 00:00:00 2001 From: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Date: Wed, 25 Sep 2024 10:10:23 -0700 Subject: [PATCH 04/10] circleci cleanup --- .../data-grid/server-side-data/ServerSideErrorHandling.js | 4 +++- .../data-grid/server-side-data/ServerSideErrorHandling.tsx | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/data/data-grid/server-side-data/ServerSideErrorHandling.js b/docs/data/data-grid/server-side-data/ServerSideErrorHandling.js index 6ea73b483a93..e7d292657902 100644 --- a/docs/data/data-grid/server-side-data/ServerSideErrorHandling.js +++ b/docs/data/data-grid/server-side-data/ServerSideErrorHandling.js @@ -104,7 +104,9 @@ export default function ServerSideErrorHandling() { setError(dataSourceError.message)} + unstable_onDataSourceError={(dataSourceError) => + setError(dataSourceError.message) + } unstable_dataSourceCache={null} apiRef={apiRef} pagination diff --git a/docs/data/data-grid/server-side-data/ServerSideErrorHandling.tsx b/docs/data/data-grid/server-side-data/ServerSideErrorHandling.tsx index dce535cb5c30..3e094b19fdf7 100644 --- a/docs/data/data-grid/server-side-data/ServerSideErrorHandling.tsx +++ b/docs/data/data-grid/server-side-data/ServerSideErrorHandling.tsx @@ -110,7 +110,9 @@ export default function ServerSideErrorHandling() { setError(dataSourceError.message)} + unstable_onDataSourceError={(dataSourceError) => + setError(dataSourceError.message) + } unstable_dataSourceCache={null} apiRef={apiRef} pagination From 86a5f454882239ab84fb5bf3b9e624e70b7e561d Mon Sep 17 00:00:00 2001 From: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Date: Thu, 26 Sep 2024 08:15:13 -0700 Subject: [PATCH 05/10] jose review --- .../src/context/ZoomProvider/useSetupPan.ts | 12 ++++++------ .../src/context/ZoomProvider/useSetupZoom.ts | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts b/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts index 4569d62ff81d..5fcc12eb6616 100644 --- a/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts +++ b/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts @@ -81,9 +81,9 @@ export const useSetupPan = () => { setZoomData(newZoomData); }; - const handleDown = (downEvent: PointerEvent) => { - eventCacheRef.current.push(downEvent); - const point = getSVGPoint(element, downEvent); + const handleDown = (event: PointerEvent) => { + eventCacheRef.current.push(event); + const point = getSVGPoint(element, event); if (!drawingArea.isPointInside(point)) { return; @@ -91,7 +91,7 @@ export const useSetupPan = () => { // If there is only one pointer, prevent selecting text if (eventCacheRef.current.length === 1) { - downEvent.preventDefault(); + event.preventDefault(); } isDraggingRef.current = true; @@ -104,9 +104,9 @@ export const useSetupPan = () => { }; }; - const handleUp = (upEvent: PointerEvent) => { + const handleUp = (event: PointerEvent) => { eventCacheRef.current.splice( - eventCacheRef.current.findIndex((eventIndex) => eventIndex.pointerId === upEvent.pointerId), + eventCacheRef.current.findIndex((cachedIndex) => cachedIndex.pointerId === event.pointerId), 1, ); setIsInteracting(false); diff --git a/packages/x-charts-pro/src/context/ZoomProvider/useSetupZoom.ts b/packages/x-charts-pro/src/context/ZoomProvider/useSetupZoom.ts index e2c9cb1453a1..5f4a50f39530 100644 --- a/packages/x-charts-pro/src/context/ZoomProvider/useSetupZoom.ts +++ b/packages/x-charts-pro/src/context/ZoomProvider/useSetupZoom.ts @@ -178,7 +178,7 @@ export const useSetupZoom = () => { function pointerUpHandler(event: PointerEvent) { eventCacheRef.current.splice( - eventCacheRef.current.findIndex((eventIndex) => eventIndex.pointerId === event.pointerId), + eventCacheRef.current.findIndex((cachedEvent) => cachedEvent.pointerId === event.pointerId), 1, ); From bddc6eb30e3b6513d4ad0b79e6ac725ea763104d Mon Sep 17 00:00:00 2001 From: Sycamore <71297412+samuelsycamore@users.noreply.github.com> Date: Thu, 26 Sep 2024 11:45:53 -0400 Subject: [PATCH 06/10] Update packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com> Signed-off-by: Sycamore <71297412+samuelsycamore@users.noreply.github.com> --- packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts b/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts index 5fcc12eb6616..84d043676a8c 100644 --- a/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts +++ b/packages/x-charts-pro/src/context/ZoomProvider/useSetupPan.ts @@ -106,7 +106,7 @@ export const useSetupPan = () => { const handleUp = (event: PointerEvent) => { eventCacheRef.current.splice( - eventCacheRef.current.findIndex((cachedIndex) => cachedIndex.pointerId === event.pointerId), + eventCacheRef.current.findIndex((cachedEvent) => cachedEvent.pointerId === event.pointerId), 1, ); setIsInteracting(false); From 7fc2ab40fd48ba129b4d2c6027e706f1ff6e3da4 Mon Sep 17 00:00:00 2001 From: Sycamore <71297412+samuelsycamore@users.noreply.github.com> Date: Mon, 30 Sep 2024 08:46:45 -0700 Subject: [PATCH 07/10] keydownEvent Signed-off-by: Sycamore <71297412+samuelsycamore@users.noreply.github.com> --- docs/src/modules/components/overview/Keyboard.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/src/modules/components/overview/Keyboard.tsx b/docs/src/modules/components/overview/Keyboard.tsx index 0d5b65785587..2d0a141601f0 100644 --- a/docs/src/modules/components/overview/Keyboard.tsx +++ b/docs/src/modules/components/overview/Keyboard.tsx @@ -417,13 +417,13 @@ export default function Keyboard() { sectionContent.focus(); if (key) { - const dispatchedEvent = new KeyboardEvent('keydown', { + const keydownEvent = new KeyboardEvent('keydown', { ...key, bubbles: true, cancelable: true, }); - sectionContent.dispatchEvent(dispatchedEvent); + sectionContent.dispatchEvent(keydownEvent); if (key.key === 'Backspace') { sectionContent.textContent = ''; From 075ec5f9db0442dbddee88a760f06892ee2f5e39 Mon Sep 17 00:00:00 2001 From: Lukas Date: Fri, 4 Oct 2024 10:15:31 +0300 Subject: [PATCH 08/10] bump monorepo --- package.json | 2 +- pnpm-lock.yaml | 179 +++++++++++++++++++++++++++++-------------------- 2 files changed, 109 insertions(+), 72 deletions(-) diff --git a/package.json b/package.json index 20d6e0e701b8..dc0949ee8873 100644 --- a/package.json +++ b/package.json @@ -95,7 +95,7 @@ "@mui/internal-markdown": "^1.0.14", "@mui/internal-test-utils": "^1.0.14", "@mui/material": "^5.16.7", - "@mui/monorepo": "github:mui/material-ui#263c7259451d5b928bbdfd299c9c0afc89dfec02", + "@mui/monorepo": "github:mui/material-ui#95fd6b5c97aca84f1f8b02bfeefddf4a55baea5c", "@mui/utils": "^5.16.6", "@next/eslint-plugin-next": "14.2.12", "@octokit/plugin-retry": "^7.1.1", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index aa891732623f..5a9f44976952 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -99,8 +99,8 @@ importers: specifier: ^5.16.7 version: 5.16.7(@emotion/react@11.13.3(@types/react@18.3.4)(react@18.3.1))(@emotion/styled@11.13.0(@emotion/react@11.13.3(@types/react@18.3.4)(react@18.3.1))(@types/react@18.3.4)(react@18.3.1))(@types/react@18.3.4)(react-dom@18.3.1(react@18.3.1))(react@18.3.1) '@mui/monorepo': - specifier: github:mui/material-ui#263c7259451d5b928bbdfd299c9c0afc89dfec02 - version: https://codeload.github.com/mui/material-ui/tar.gz/263c7259451d5b928bbdfd299c9c0afc89dfec02(encoding@0.1.13) + specifier: github:mui/material-ui#95fd6b5c97aca84f1f8b02bfeefddf4a55baea5c + version: https://codeload.github.com/mui/material-ui/tar.gz/95fd6b5c97aca84f1f8b02bfeefddf4a55baea5c(encoding@0.1.13) '@mui/utils': specifier: ^5.16.6 version: 5.16.6(@types/react@18.3.4)(react@18.3.1) @@ -3213,10 +3213,10 @@ packages: '@types/react': optional: true - '@mui/monorepo@https://codeload.github.com/mui/material-ui/tar.gz/263c7259451d5b928bbdfd299c9c0afc89dfec02': - resolution: {tarball: https://codeload.github.com/mui/material-ui/tar.gz/263c7259451d5b928bbdfd299c9c0afc89dfec02} - version: 6.1.1 - engines: {pnpm: 9.10.0} + '@mui/monorepo@https://codeload.github.com/mui/material-ui/tar.gz/95fd6b5c97aca84f1f8b02bfeefddf4a55baea5c': + resolution: {tarball: https://codeload.github.com/mui/material-ui/tar.gz/95fd6b5c97aca84f1f8b02bfeefddf4a55baea5c} + version: 6.1.2 + engines: {pnpm: 9.11.0} '@mui/private-theming@5.16.6': resolution: {integrity: sha512-rAk+Rh8Clg7Cd7shZhyt2HGTTE5wYKNSJ5sspf28Fqm/PZ69Er9o6KX25g03/FG2dfpg5GCwZh/xOojiTfm3hw==} @@ -3889,8 +3889,8 @@ packages: '@sinonjs/text-encoding@0.7.2': resolution: {integrity: sha512-sXXKG+uL9IrKqViTtao2Ws6dy0znu9sOaP1di/jKGW1M6VssO8vlpXCQcpZ+jisQ1tTFAC5Jo/EOzFbggBagFQ==} - '@slack/bolt@3.21.4': - resolution: {integrity: sha512-4PqOuHXcVt8KxjKiLdLIqZp8285zdiYLj7HrrKvVHnUNbkD0l16HZxtMfIEe07REQ+vmM1mrqCiZqe9dPAMucA==} + '@slack/bolt@3.22.0': + resolution: {integrity: sha512-iKDqGPEJDnrVwxSVlFW6OKTkijd7s4qLBeSufoBsTM0reTyfdp/5izIQVkxNfzjHi3o6qjdYbRXkYad5HBsBog==} engines: {node: '>=14.21.3', npm: '>=6.14.18'} '@slack/logger@3.0.0': @@ -3913,8 +3913,8 @@ packages: resolution: {integrity: sha512-OAQVtKYIgBVNRmgIoiTjorGPTlgfcfstU3XYYCBA+czlB9aGcKb9MQc+6Jovi4gq3S98yP/GPBZsJSI/2mHKDQ==} engines: {node: '>= 12.13.0', npm: '>= 6.12.0'} - '@slack/web-api@6.12.1': - resolution: {integrity: sha512-dXHyHkvvziqkDdZlPRnUl/H2uvnUmdJ5B7kxiH1HIgHe18vcbUk1zjU/XCZgJFhxGeq5Zwa95Z+SbNW9mbRhtw==} + '@slack/web-api@6.13.0': + resolution: {integrity: sha512-dv65crIgdh9ZYHrevLU6XFHTQwTyDmNqEqzuIrV+Vqe/vgiG6w37oex5ePDU1RGm2IJ90H8iOvHFvzdEO/vB+g==} engines: {node: '>= 12.13.0', npm: '>= 6.12.0'} '@socket.io/component-emitter@3.1.0': @@ -4895,14 +4895,14 @@ packages: bluebird@3.4.7: resolution: {integrity: sha512-iD3898SR7sWVRHbiQv+sHUtHnMvC1o3nW5rAcqnq3uOn07DSAppZYUkIGslDz6gXC7HfunPe7YVBgoEJASPcHA==} - body-parser@1.20.1: - resolution: {integrity: sha512-jWi7abTbYwajOytWCQc37VulmWiRae5RyTpaCyDcS5/lMdtwSz5lOpDE67srw/HYe35f1z3fDQw+3txg7gNtWw==} - engines: {node: '>= 0.8', npm: 1.2.8000 || >= 1.4.16} - body-parser@1.20.2: resolution: {integrity: sha512-ml9pReCu3M61kGlqoTm2umSXTlRTuGTx0bfYj+uIUKKYycG5NtSbeetV3faSU6R7ajOPw0g/J1PvK4qNy7s5bA==} engines: {node: '>= 0.8', npm: 1.2.8000 || >= 1.4.16} + body-parser@1.20.3: + resolution: {integrity: sha512-7rAxByjUMqQ3/bHJy7D6OGXvx/MMc4IqBn/X0fcM1QUcAItpZrBEYhWGem+tzXH90c+G01ypMcYJBO9Y30203g==} + engines: {node: '>= 0.8', npm: 1.2.8000 || >= 1.4.16} + boolbase@1.0.0: resolution: {integrity: sha512-JZOSA7Mo9sNGB8+UjSgzdLtokWAky1zbztM3WRLCbZ70/3cTANmQmOdR7y2g+J0e2WXywy1yS468tY+IruqEww==} @@ -5347,8 +5347,8 @@ packages: resolution: {integrity: sha512-aSWTXFzaKWkvHO1Ny/s+ePFpvKsPnjc551iI41v3ny/ow6tBG5Vd+FuqGNhh1LxOmVzOlGUriIlOaokOvhaStA==} engines: {node: '>= 0.6'} - cookie@0.5.0: - resolution: {integrity: sha512-YZ3GUyn/o8gfKJlnlX7g7xq4gyO6OSuhGPKaaGssGB2qgDUS0gPgtTvoyZLTt9Ab6dC4hfc9dV5arkvc/OCmrw==} + cookie@0.6.0: + resolution: {integrity: sha512-U71cyTamuh1CRNCfpGY6to28lxvNwPG4Guz/EVjgf3Jmzv0vlDp1atT9eS5dDjMYHucpHbWns6Lwf3BKz6svdw==} engines: {node: '>= 0.6'} core-js-compat@3.38.1: @@ -5781,6 +5781,10 @@ packages: resolution: {integrity: sha512-TPJXq8JqFaVYm2CWmPvnP2Iyo4ZSM7/QKcSmuMLDObfpH5fi7RUGmd/rTDf+rut/saiDiQEeVTNgAmJEdAOx0w==} engines: {node: '>= 0.8'} + encodeurl@2.0.0: + resolution: {integrity: sha512-Q0n9HRi4m6JuGIV1eFlmvJB7ZEVxu93IrMyiMsGC0lrMJMWzRgx6WGquyfQgZVb31vhGgXnfmPNNXmxnOkRBrg==} + engines: {node: '>= 0.8'} + encoding@0.1.13: resolution: {integrity: sha512-ETBauow1T35Y/WZMkio9jiM0Z5xjHHmJ4XmjZOq1l/dXz3lr2sRn87nJy20RupqSh1F2m3HHPSp8ShIPQJrJ3A==} @@ -6158,6 +6162,10 @@ packages: resolution: {integrity: sha512-gdhefCCNy/8tpH/2+ajP9IQc14vXchNdd0weyzSJEFURhRMGncQ+zKFxwjAufIewPEJm9BPOaJnvg2UtlH2gPQ==} engines: {node: ^18.19.0 || >=20.5.0} + execa@9.4.0: + resolution: {integrity: sha512-yKHlle2YGxZE842MERVIplWwNH5VYmqqcPFgtnlU//K8gxuFFXu0pwd/CrfXTumFpeEiufsP7+opT/bPJa1yVw==} + engines: {node: ^18.19.0 || >=20.5.0} + expand-tilde@2.0.2: resolution: {integrity: sha512-A5EmesHW6rfnZ9ysHQjPdJRni0SRar0tjtG5MNtm9n5TUvsYU8oozprtRD4AqHxcZWWlVuAmQo2nWKfN9oyjTw==} engines: {node: '>=0.10.0'} @@ -6165,8 +6173,8 @@ packages: exponential-backoff@3.1.1: resolution: {integrity: sha512-dX7e/LHVJ6W3DE1MHWi9S1EYzDESENfLrYohG2G++ovZrYOkm4Knwa0mc1cn84xJOR4KEU0WSchhLbd0UklbHw==} - express@4.18.2: - resolution: {integrity: sha512-5/PsL6iGPdfQ/lKM1UuielYgv3BUoJfz1aUwU9vHZ+J7gyvwdQXFEBIEIaxeGf0GIcreATNyBExtalisDbuMqQ==} + express@4.21.0: + resolution: {integrity: sha512-VqcNGcj/Id5ZT1LZ/cfihi3ttTn+NJmkli2eZADigjq29qTlWi/hAQ43t/VLPq8+UX06FCEx3ByOYet6ZFblng==} engines: {node: '>= 0.10.0'} extend-shallow@2.0.1: @@ -6243,8 +6251,8 @@ packages: resolution: {integrity: sha512-aAWcW57uxVNrQZqFXjITpW3sIUQmHGG3qSb9mUah9MgMC4NeWhNOlNjXEYq3HjRAvL6arUviZGGJsBg6z0zsWA==} engines: {node: '>= 0.8'} - finalhandler@1.2.0: - resolution: {integrity: sha512-5uXcUVftlQMFnWC9qu/svkWv3GTd2PfUhK/3PLkYNAe7FbqJMt3515HaxE6eRL74GdsriiwujiawdaB1BpEISg==} + finalhandler@1.3.1: + resolution: {integrity: sha512-6BN9trH7bp3qvnrRyzsBz+g3lZxTNZTbVO2EV1CS0WIcDbawYVdYvGflME/9QP0h0pYlCDBCTjYa9nZzMDpyxQ==} engines: {node: '>= 0.8'} find-babel-config@2.1.1: @@ -7687,8 +7695,8 @@ packages: resolution: {integrity: sha512-r85E3NdZ+mpYk1C6RjPFEMSE+s1iZMuHtsHAqY0DT3jZczl0diWUZ8g6oU7h0M9cD2EL+PzaYghhCLzR0ZNn5Q==} engines: {node: '>=10'} - merge-descriptors@1.0.1: - resolution: {integrity: sha512-cCi6g3/Zr1iqQi6ySbseM1Xvooa98N0w31jzUYrXPX2xqObmFGHJ0tQ5u74H3mVh7wLouTseZyYIq39g8cNp1w==} + merge-descriptors@1.0.3: + resolution: {integrity: sha512-gaNvAS7TZ897/rVaZ0nMtAyxNyi/pdbjbAwUpFQpN70GqnVfOiXpeUUMKRBmzXaSQ8DdTX4/0ms62r2K+hE6mQ==} merge-stream@2.0.0: resolution: {integrity: sha512-abv/qOcuPfk3URPfDzmZU1LKmuw8kT+0nIHvKrKgFrwifol/doWcdA4ZqsWQ8ENrFKkd67Mfpo/LovbIUsbt3w==} @@ -8096,6 +8104,10 @@ packages: resolution: {integrity: sha512-ppwTtiJZq0O/ai0z7yfudtBpWIoxM8yE6nHi1X47eFR2EWORqfbu6CnPlNsjeN683eT0qG6H/Pyf9fCcvjnnnQ==} engines: {node: ^12.20.0 || ^14.13.1 || >=16.0.0} + npm-run-path@6.0.0: + resolution: {integrity: sha512-9qny7Z9DsQU8Ou39ERsPU4OZQlSTP47ShQzuKZ6PRXpYLtIFgl/DEBYEXKlvcEa+9tHVcK8CF81Y2V72qaZhWA==} + engines: {node: '>=18'} + nprogress@0.2.0: resolution: {integrity: sha512-I19aIingLgR1fmhftnbWWO3dXc0hSxqHQHQb3H8m+K3TnEn/iSeTZZOyvKXWqQESMwuUVnatlCnZdLBZZt2VSA==} @@ -8447,8 +8459,8 @@ packages: resolution: {integrity: sha512-ypGJsmGtdXUOeM5u93TyeIEfEhM6s+ljAhrk5vAvSx8uyY/02OvrZnA0YNGUrPXfpJMgI1ODd3nwz8Npx4O4cg==} engines: {node: 20 || >=22} - path-to-regexp@0.1.7: - resolution: {integrity: sha512-5DFkuoqlv1uYQKxy8omFBeJPQcdoE07Kv2sferDCrAq1ohOU+MSDswDIbnx3YAM60qIOnYa53wBhXW0EbMonrQ==} + path-to-regexp@0.1.10: + resolution: {integrity: sha512-7lf7qcQidTku0Gu3YDPc8DJ1q7OOucfa/BSsIwjuh56VU7katFvuM8hULfkwB3Fns/rsVF7PwPKVw1sl5KQS9w==} path-to-regexp@2.2.1: resolution: {integrity: sha512-gu9bD6Ta5bwGrrU8muHzVOBFFREpp2iRkVfhBJahwJ6p6Xw20SjT0MxLnwkjOibQmGSYhiUnf2FLe7k+jcFmGQ==} @@ -8713,6 +8725,10 @@ packages: resolution: {integrity: sha512-tDNIz22aBzCDxLtVH++VnTfzxlfeK5CbqohpSqpJgj1Wg/cQbStNAz3NuqCs5vV+pjBsK4x4pN9HlVh7rcYRiA==} engines: {node: '>=0.6'} + qs@6.13.0: + resolution: {integrity: sha512-+38qI9SOr8tfZ4QmJNplMUxqjbe7LKvvZgWdExBOmd+egZTtjLB67Gu0HRX3u/XOq7UU2Nx6nsjvS16Z9uwfpg==} + engines: {node: '>=0.6'} + querystringify@2.2.0: resolution: {integrity: sha512-FIqgj2EUvTa7R50u0rGsyTftzjYmv/a3hO345bZNrqabNqjtgiDMgmo4mkUjd+nzU5oF3dClKqFIPUKybUyqoQ==} @@ -8737,10 +8753,6 @@ packages: resolution: {integrity: sha512-Hrgsx+orqoygnmhFbKaHE6c296J+HTAQXoxEF6gNupROmmGJRoyzfG3ccAveqCBrwr/2yxQ5BVd/GTl5agOwSg==} engines: {node: '>= 0.6'} - raw-body@2.5.1: - resolution: {integrity: sha512-qqJBtEyVgS0ZmPGdCFPWJ3FreoqvG4MVQln/kCgF7Olq95IbOp0/BWyMwbdtn4VTvkM8Y7khCQ2Xgk/tcrCXig==} - engines: {node: '>= 0.8'} - raw-body@2.5.2: resolution: {integrity: sha512-8zGqypfENjCIqGhgXToC8aB2r7YrBX+AQAfIPs/Mlk+BtPTztOvTS01NRW/3Eh60J+a48lt8qsCzirQ6loCVfA==} engines: {node: '>= 0.8'} @@ -9109,8 +9121,8 @@ packages: engines: {node: '>=10'} hasBin: true - send@0.18.0: - resolution: {integrity: sha512-qqWzuOjSFOuqPjFe4NOsMLafToQQwBSOEpS+FwEt3A2V3vKubTquT3vmLTQpFgMXp8AlFWFuP1qKaJZOtPpVXg==} + send@0.19.0: + resolution: {integrity: sha512-dW41u5VfLXu8SJh5bwRmyYUbAoSB3c9uQh6L8h/KtsFREPWpbX1lrljJo186Jc4nmci/sGUZ9a0a0J2zgfq2hw==} engines: {node: '>= 0.8.0'} serialize-javascript@6.0.2: @@ -9119,8 +9131,8 @@ packages: serve-handler@6.1.5: resolution: {integrity: sha512-ijPFle6Hwe8zfmBxJdE+5fta53fdIY0lHISJvuikXB3VYFafRjMRpOffSPvCYsbKyBA7pvy9oYr/BT1O3EArlg==} - serve-static@1.15.0: - resolution: {integrity: sha512-XGuRDNjXUijsUL0vl6nSD7cwURuzEgglbOaFuZM9g3kwDXOWVTck0jLzjPzGD+TazWbboZYu52/9/XPdUgne9g==} + serve-static@1.16.2: + resolution: {integrity: sha512-VqpjJZKadQB/PEbEwvFdO43Ax5dFBZ2UECszz8bQ7pi7wt//PWe1P6MN7eCnjsatYtBT6EuiClbjSWP2WrIoTw==} engines: {node: '>= 0.8.0'} serve@14.2.3: @@ -9786,6 +9798,10 @@ packages: resolution: {integrity: sha512-lRfVq8fE8gz6QMBuDM6a+LO3IAzTi05H6gCVaUpir2E1Rwpo4ZUog45KpNXKC/Mn3Yb9UDuHumeFTo9iV/D9FQ==} engines: {node: '>=18'} + unicorn-magic@0.3.0: + resolution: {integrity: sha512-+QBBXBCvifc56fsbuxZQ6Sic3wqqc3WWaqxs58gvJrcOuN83HGTCwz3oS5phzU9LthRNE9VrJCFCLUgHeeFnfA==} + engines: {node: '>=18'} + unified@11.0.5: resolution: {integrity: sha512-xKvGhPWw3k84Qjh8bI3ZeJjqnyadK+GEFtazSfZv/rKeTkTjOJho6mFqh2SM96iIcZokxiOpg78GazTSg8+KHA==} @@ -12100,12 +12116,12 @@ snapshots: '@emotion/styled': 11.13.0(@emotion/react@11.13.3(@types/react@18.3.4)(react@18.3.1))(@types/react@18.3.4)(react@18.3.1) '@types/react': 18.3.4 - '@mui/monorepo@https://codeload.github.com/mui/material-ui/tar.gz/263c7259451d5b928bbdfd299c9c0afc89dfec02(encoding@0.1.13)': + '@mui/monorepo@https://codeload.github.com/mui/material-ui/tar.gz/95fd6b5c97aca84f1f8b02bfeefddf4a55baea5c(encoding@0.1.13)': dependencies: '@googleapis/sheets': 9.3.1(encoding@0.1.13) '@netlify/functions': 2.8.1 - '@slack/bolt': 3.21.4 - execa: 9.3.1 + '@slack/bolt': 3.22.0 + execa: 9.4.0 google-auth-library: 9.14.1(encoding@0.1.13) transitivePeerDependencies: - bufferutil @@ -12872,18 +12888,18 @@ snapshots: '@sinonjs/text-encoding@0.7.2': {} - '@slack/bolt@3.21.4': + '@slack/bolt@3.22.0': dependencies: '@slack/logger': 4.0.0 '@slack/oauth': 2.6.3 '@slack/socket-mode': 1.3.6 '@slack/types': 2.13.0 - '@slack/web-api': 6.12.1 + '@slack/web-api': 6.13.0 '@types/express': 4.17.21 '@types/promise.allsettled': 1.0.6 '@types/tsscmp': 1.0.2 axios: 1.7.5(debug@4.3.6) - express: 4.18.2 + express: 4.21.0 path-to-regexp: 8.1.0 promise.allsettled: 1.0.7 raw-body: 2.5.2 @@ -12905,7 +12921,7 @@ snapshots: '@slack/oauth@2.6.3': dependencies: '@slack/logger': 3.0.0 - '@slack/web-api': 6.12.1 + '@slack/web-api': 6.13.0 '@types/jsonwebtoken': 8.5.9 '@types/node': 20.16.5 jsonwebtoken: 9.0.2 @@ -12916,7 +12932,7 @@ snapshots: '@slack/socket-mode@1.3.6': dependencies: '@slack/logger': 3.0.0 - '@slack/web-api': 6.12.1 + '@slack/web-api': 6.13.0 '@types/node': 20.16.5 '@types/ws': 7.4.7 eventemitter3: 5.0.1 @@ -12929,7 +12945,7 @@ snapshots: '@slack/types@2.13.0': {} - '@slack/web-api@6.12.1': + '@slack/web-api@6.13.0': dependencies: '@slack/logger': 3.0.0 '@slack/types': 2.13.0 @@ -14085,7 +14101,7 @@ snapshots: bluebird@3.4.7: {} - body-parser@1.20.1: + body-parser@1.20.2: dependencies: bytes: 3.1.2 content-type: 1.0.5 @@ -14096,13 +14112,13 @@ snapshots: iconv-lite: 0.4.24 on-finished: 2.4.1 qs: 6.11.0 - raw-body: 2.5.1 + raw-body: 2.5.2 type-is: 1.6.18 unpipe: 1.0.0 transitivePeerDependencies: - supports-color - body-parser@1.20.2: + body-parser@1.20.3: dependencies: bytes: 3.1.2 content-type: 1.0.5 @@ -14112,7 +14128,7 @@ snapshots: http-errors: 2.0.0 iconv-lite: 0.4.24 on-finished: 2.4.1 - qs: 6.11.0 + qs: 6.13.0 raw-body: 2.5.2 type-is: 1.6.18 unpipe: 1.0.0 @@ -14598,7 +14614,7 @@ snapshots: cookie@0.4.2: {} - cookie@0.5.0: {} + cookie@0.6.0: {} core-js-compat@3.38.1: dependencies: @@ -15053,6 +15069,8 @@ snapshots: encodeurl@1.0.2: {} + encodeurl@2.0.0: {} + encoding@0.1.13: dependencies: iconv-lite: 0.6.3 @@ -15680,40 +15698,55 @@ snapshots: strip-final-newline: 4.0.0 yoctocolors: 2.0.2 + execa@9.4.0: + dependencies: + '@sindresorhus/merge-streams': 4.0.0 + cross-spawn: 7.0.3 + figures: 6.1.0 + get-stream: 9.0.1 + human-signals: 8.0.0 + is-plain-obj: 4.1.0 + is-stream: 4.0.1 + npm-run-path: 6.0.0 + pretty-ms: 9.0.0 + signal-exit: 4.1.0 + strip-final-newline: 4.0.0 + yoctocolors: 2.0.2 + expand-tilde@2.0.2: dependencies: homedir-polyfill: 1.0.3 exponential-backoff@3.1.1: {} - express@4.18.2: + express@4.21.0: dependencies: accepts: 1.3.8 array-flatten: 1.1.1 - body-parser: 1.20.1 + body-parser: 1.20.3 content-disposition: 0.5.4 content-type: 1.0.5 - cookie: 0.5.0 + cookie: 0.6.0 cookie-signature: 1.0.6 debug: 2.6.9 depd: 2.0.0 - encodeurl: 1.0.2 + encodeurl: 2.0.0 escape-html: 1.0.3 etag: 1.8.1 - finalhandler: 1.2.0 + finalhandler: 1.3.1 fresh: 0.5.2 http-errors: 2.0.0 - merge-descriptors: 1.0.1 + merge-descriptors: 1.0.3 methods: 1.1.2 on-finished: 2.4.1 parseurl: 1.3.3 - path-to-regexp: 0.1.7 + path-to-regexp: 0.1.10 proxy-addr: 2.0.7 - qs: 6.11.0 + qs: 6.13.0 range-parser: 1.2.1 safe-buffer: 5.2.1 - send: 0.18.0 - serve-static: 1.15.0 + send: 0.19.0 + serve-static: 1.16.2 setprototypeof: 1.2.0 statuses: 2.0.1 type-is: 1.6.18 @@ -15803,10 +15836,10 @@ snapshots: transitivePeerDependencies: - supports-color - finalhandler@1.2.0: + finalhandler@1.3.1: dependencies: debug: 2.6.9 - encodeurl: 1.0.2 + encodeurl: 2.0.0 escape-html: 1.0.3 on-finished: 2.4.1 parseurl: 1.3.3 @@ -17528,7 +17561,7 @@ snapshots: type-fest: 0.18.1 yargs-parser: 20.2.9 - merge-descriptors@1.0.1: {} + merge-descriptors@1.0.3: {} merge-stream@2.0.0: {} @@ -18031,6 +18064,11 @@ snapshots: dependencies: path-key: 4.0.0 + npm-run-path@6.0.0: + dependencies: + path-key: 4.0.0 + unicorn-magic: 0.3.0 + nprogress@0.2.0: {} nth-check@2.1.1: @@ -18477,7 +18515,7 @@ snapshots: lru-cache: 11.0.1 minipass: 7.1.2 - path-to-regexp@0.1.7: {} + path-to-regexp@0.1.10: {} path-to-regexp@2.2.1: {} @@ -18698,6 +18736,10 @@ snapshots: dependencies: side-channel: 1.0.6 + qs@6.13.0: + dependencies: + side-channel: 1.0.6 + querystringify@2.2.0: {} queue-microtask@1.2.3: {} @@ -18714,13 +18756,6 @@ snapshots: range-parser@1.2.1: {} - raw-body@2.5.1: - dependencies: - bytes: 3.1.2 - http-errors: 2.0.0 - iconv-lite: 0.4.24 - unpipe: 1.0.0 - raw-body@2.5.2: dependencies: bytes: 3.1.2 @@ -19154,7 +19189,7 @@ snapshots: semver@7.6.3: {} - send@0.18.0: + send@0.19.0: dependencies: debug: 2.6.9 depd: 2.0.0 @@ -19187,12 +19222,12 @@ snapshots: path-to-regexp: 2.2.1 range-parser: 1.2.0 - serve-static@1.15.0: + serve-static@1.16.2: dependencies: - encodeurl: 1.0.2 + encodeurl: 2.0.0 escape-html: 1.0.3 parseurl: 1.3.3 - send: 0.18.0 + send: 0.19.0 transitivePeerDependencies: - supports-color @@ -19914,6 +19949,8 @@ snapshots: unicorn-magic@0.1.0: {} + unicorn-magic@0.3.0: {} + unified@11.0.5: dependencies: '@types/unist': 3.0.3 From ff3c772b3600f9694669a5c6ff3749d711640982 Mon Sep 17 00:00:00 2001 From: Lukas Date: Fri, 4 Oct 2024 10:16:01 +0300 Subject: [PATCH 09/10] dedupe --- pnpm-lock.yaml | 68 +++++--------------------------------------------- 1 file changed, 6 insertions(+), 62 deletions(-) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 5a9f44976952..522cfa69c320 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -938,7 +938,7 @@ importers: version: 4.1.0 execa: specifier: ^9.3.1 - version: 9.3.1 + version: 9.4.0 internmap: specifier: ^2.0.3 version: 2.0.3 @@ -3085,7 +3085,7 @@ packages: resolution: {integrity: sha512-I/lGHztkCzvwlXpjD2+SNmvNQvB4227xBXhISPjEaJUXGImOQ9f3D2Yj/T3KasSI/h0MLWy74X0J6clhPmsRbQ==} engines: {node: '>=12.0.0'} peerDependencies: - '@types/react': ^17.0.0 || ^18.0.0 + '@types/react': ^18.3.4 react: ^17.0.0 || ^18.0.0 react-dom: ^17.0.0 || ^18.0.0 peerDependenciesMeta: @@ -4895,10 +4895,6 @@ packages: bluebird@3.4.7: resolution: {integrity: sha512-iD3898SR7sWVRHbiQv+sHUtHnMvC1o3nW5rAcqnq3uOn07DSAppZYUkIGslDz6gXC7HfunPe7YVBgoEJASPcHA==} - body-parser@1.20.2: - resolution: {integrity: sha512-ml9pReCu3M61kGlqoTm2umSXTlRTuGTx0bfYj+uIUKKYycG5NtSbeetV3faSU6R7ajOPw0g/J1PvK4qNy7s5bA==} - engines: {node: '>= 0.8', npm: 1.2.8000 || >= 1.4.16} - body-parser@1.20.3: resolution: {integrity: sha512-7rAxByjUMqQ3/bHJy7D6OGXvx/MMc4IqBn/X0fcM1QUcAItpZrBEYhWGem+tzXH90c+G01ypMcYJBO9Y30203g==} engines: {node: '>= 0.8', npm: 1.2.8000 || >= 1.4.16} @@ -6158,10 +6154,6 @@ packages: resolution: {integrity: sha512-VyhnebXciFV2DESc+p6B+y0LjSm0krU4OgJN44qFAhBY0TJ+1V61tYD2+wHusZ6F9n5K+vl8k0sTy7PEfV4qpg==} engines: {node: '>=16.17'} - execa@9.3.1: - resolution: {integrity: sha512-gdhefCCNy/8tpH/2+ajP9IQc14vXchNdd0weyzSJEFURhRMGncQ+zKFxwjAufIewPEJm9BPOaJnvg2UtlH2gPQ==} - engines: {node: ^18.19.0 || >=20.5.0} - execa@9.4.0: resolution: {integrity: sha512-yKHlle2YGxZE842MERVIplWwNH5VYmqqcPFgtnlU//K8gxuFFXu0pwd/CrfXTumFpeEiufsP7+opT/bPJa1yVw==} engines: {node: ^18.19.0 || >=20.5.0} @@ -8717,14 +8709,6 @@ packages: resolution: {integrity: sha512-8YOJEHtxpySA3fFDyCRxA+UUV+fA+rTWnuWvylOK/NCjhY+b4ocCtmu8TtsWb+mYeU+GCHf/S66KZF/AsteKHg==} engines: {node: '>=0.9'} - qs@6.11.0: - resolution: {integrity: sha512-MvjoMCJwEarSbUYk5O+nmoSzSutSsTwF85zcHPQ9OrlFoZOYIjaqBAJIqIXjptyD5vThxGq52Xu/MaJzRkIk4Q==} - engines: {node: '>=0.6'} - - qs@6.11.2: - resolution: {integrity: sha512-tDNIz22aBzCDxLtVH++VnTfzxlfeK5CbqohpSqpJgj1Wg/cQbStNAz3NuqCs5vV+pjBsK4x4pN9HlVh7rcYRiA==} - engines: {node: '>=0.6'} - qs@6.13.0: resolution: {integrity: sha512-+38qI9SOr8tfZ4QmJNplMUxqjbe7LKvvZgWdExBOmd+egZTtjLB67Gu0HRX3u/XOq7UU2Nx6nsjvS16Z9uwfpg==} engines: {node: '>=0.6'} @@ -11703,12 +11687,12 @@ snapshots: '@gitbeaker/core@38.12.1': dependencies: '@gitbeaker/requester-utils': 38.12.1 - qs: 6.11.2 + qs: 6.13.0 xcase: 2.0.1 '@gitbeaker/requester-utils@38.12.1': dependencies: - qs: 6.11.2 + qs: 6.13.0 xcase: 2.0.1 '@gitbeaker/rest@38.12.1': @@ -14101,23 +14085,6 @@ snapshots: bluebird@3.4.7: {} - body-parser@1.20.2: - dependencies: - bytes: 3.1.2 - content-type: 1.0.5 - debug: 2.6.9 - depd: 2.0.0 - destroy: 1.2.0 - http-errors: 2.0.0 - iconv-lite: 0.4.24 - on-finished: 2.4.1 - qs: 6.11.0 - raw-body: 2.5.2 - type-is: 1.6.18 - unpipe: 1.0.0 - transitivePeerDependencies: - - supports-color - body-parser@1.20.3: dependencies: bytes: 3.1.2 @@ -15683,21 +15650,6 @@ snapshots: signal-exit: 4.1.0 strip-final-newline: 3.0.0 - execa@9.3.1: - dependencies: - '@sindresorhus/merge-streams': 4.0.0 - cross-spawn: 7.0.3 - figures: 6.1.0 - get-stream: 9.0.1 - human-signals: 8.0.0 - is-plain-obj: 4.1.0 - is-stream: 4.0.1 - npm-run-path: 5.3.0 - pretty-ms: 9.0.0 - signal-exit: 4.1.0 - strip-final-newline: 4.0.0 - yoctocolors: 2.0.2 - execa@9.4.0: dependencies: '@sindresorhus/merge-streams': 4.0.0 @@ -16232,7 +16184,7 @@ snapshots: extend: 3.0.2 gaxios: 6.1.1(encoding@0.1.13) google-auth-library: 9.14.1(encoding@0.1.13) - qs: 6.11.2 + qs: 6.13.0 url-template: 2.0.8 uuid: 9.0.1 transitivePeerDependencies: @@ -17071,7 +17023,7 @@ snapshots: karma@6.4.4: dependencies: '@colors/colors': 1.5.0 - body-parser: 1.20.2 + body-parser: 1.20.3 braces: 3.0.3 chokidar: 3.6.0 connect: 3.7.0 @@ -18728,14 +18680,6 @@ snapshots: qjobs@1.2.0: {} - qs@6.11.0: - dependencies: - side-channel: 1.0.6 - - qs@6.11.2: - dependencies: - side-channel: 1.0.6 - qs@6.13.0: dependencies: side-channel: 1.0.6 From 59093fd3ae132f59d8113c832ab40ad5cdd0672b Mon Sep 17 00:00:00 2001 From: Lukas Date: Fri, 4 Oct 2024 10:25:50 +0300 Subject: [PATCH 10/10] Update `Error` usage --- packages/x-charts/src/ChartContainer/useDefaultizeAxis.ts | 2 +- packages/x-charts/src/ChartsAxis/ChartsAxis.tsx | 8 ++++---- packages/x-charts/src/context/ZAxisContextProvider.tsx | 2 +- packages/x-charts/src/internals/getPercentageValue.ts | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/x-charts/src/ChartContainer/useDefaultizeAxis.ts b/packages/x-charts/src/ChartContainer/useDefaultizeAxis.ts index e85f4175832c..a260517f0ba0 100644 --- a/packages/x-charts/src/ChartContainer/useDefaultizeAxis.ts +++ b/packages/x-charts/src/ChartContainer/useDefaultizeAxis.ts @@ -25,7 +25,7 @@ const defaultizeAxis = ( return axisConfig; } if (dataset === undefined) { - throw Error(`MUI X: ${axisName}-axis uses \`dataKey\` but no \`dataset\` is provided.`); + throw new Error(`MUI X: ${axisName}-axis uses \`dataKey\` but no \`dataset\` is provided.`); } return { ...axisConfig, diff --git a/packages/x-charts/src/ChartsAxis/ChartsAxis.tsx b/packages/x-charts/src/ChartsAxis/ChartsAxis.tsx index ff2b06bd2733..e34f231ab416 100644 --- a/packages/x-charts/src/ChartsAxis/ChartsAxis.tsx +++ b/packages/x-charts/src/ChartsAxis/ChartsAxis.tsx @@ -98,7 +98,7 @@ function ChartsAxis(props: ChartsAxisProps) { const rightId = getAxisId(rightAxis, yAxisIds[0]); if (topId !== null && !xAxis[topId]) { - throw Error( + throw new Error( [ `MUI X: id used for top axis "${topId}" is not defined.`, `Available ids are: ${xAxisIds.join(', ')}.`, @@ -106,7 +106,7 @@ function ChartsAxis(props: ChartsAxisProps) { ); } if (leftId !== null && !yAxis[leftId]) { - throw Error( + throw new Error( [ `MUI X: id used for left axis "${leftId}" is not defined.`, `Available ids are: ${yAxisIds.join(', ')}.`, @@ -114,7 +114,7 @@ function ChartsAxis(props: ChartsAxisProps) { ); } if (rightId !== null && !yAxis[rightId]) { - throw Error( + throw new Error( [ `MUI X: id used for right axis "${rightId}" is not defined.`, `Available ids are: ${yAxisIds.join(', ')}.`, @@ -122,7 +122,7 @@ function ChartsAxis(props: ChartsAxisProps) { ); } if (bottomId !== null && !xAxis[bottomId]) { - throw Error( + throw new Error( [ `MUI X: id used for bottom axis "${bottomId}" is not defined.`, `Available ids are: ${xAxisIds.join(', ')}.`, diff --git a/packages/x-charts/src/context/ZAxisContextProvider.tsx b/packages/x-charts/src/context/ZAxisContextProvider.tsx index 93a08641f452..0c028a6e7fc9 100644 --- a/packages/x-charts/src/context/ZAxisContextProvider.tsx +++ b/packages/x-charts/src/context/ZAxisContextProvider.tsx @@ -48,7 +48,7 @@ function ZAxisContextProvider(props: ZAxisContextProviderProps) { return axisConfig; } if (dataset === undefined) { - throw Error('MUI X: z-axis uses `dataKey` but no `dataset` is provided.'); + throw new Error('MUI X: z-axis uses `dataKey` but no `dataset` is provided.'); } return { ...axisConfig, diff --git a/packages/x-charts/src/internals/getPercentageValue.ts b/packages/x-charts/src/internals/getPercentageValue.ts index 85f843f10852..3e2f4589f912 100644 --- a/packages/x-charts/src/internals/getPercentageValue.ts +++ b/packages/x-charts/src/internals/getPercentageValue.ts @@ -24,7 +24,7 @@ export function getPercentageValue(value: number | string, refValue: number) { return val; } } - throw Error( + throw new Error( `MUI X: Received an unknown value "${value}". It should be a number, or a string with a percentage value.`, ); }