[test] Allow tests to run for up to 5 instead of 4 seconds #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
test-slow-tests
branch
from
6b4ec0f to
6e4d353
Compare
dtassone
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use 5 seconds in the main repository, while we have tests that are slower because they test a bigger component here. This seems like a logical step. I worked on it after seeing: https://app.circleci.com/pipelines/github/mui-org/material-ui-x/6089/workflows/f3da1253-f8e8-4876-aac0-63ffefd32ed5/jobs/32074
We could even do 6s to be honest, no real preferences.