[DataGrid] Avoid allocations in hydrateRowsMeta
#9121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
performance
component: data grid
Netlify deploy previewNetlify deploy preview: https://deploy-preview-9121--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
romgrk
commented
May 26, 2023
Comment on lines
-147
to
+154
| const existingBaseSizes = Object.entries(sizes).reduce<Record<string, number>>( | ||
| (acc, [key, size]) => { | ||
| if (/^base[A-Z]/.test(key)) { | ||
| acc[key] = size; | ||
| } | ||
| return acc; | ||
| }, | ||
| {}, | ||
| ); | ||
|
|
||
| // We use an object to make simple to check if a height is already added or not | ||
| const initialHeights: Record<string, number> = { | ||
| ...existingBaseSizes, | ||
| baseCenter: baseRowHeight, | ||
| }; | ||
| const initialHeights = {} as Record<string, number>; | ||
| /* eslint-disable-next-line no-restricted-syntax */ | ||
| for (const key in sizes) { | ||
| if (/^base[A-Z]/.test(key)) { | ||
| initialHeights[key] = sizes[key]; | ||
| } | ||
| } | ||
| initialHeights.baseCenter = baseRowHeight; |
There was a problem hiding this comment.
I love functionnal programming, but FP is always slower in JS :|
MBilalShafi
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids object allocations in
hydrateRowsMeta. For large datasets, the costs are quite high. This is compounded by the fact that we create our objects with{ ...spread }, and_objectSpread2is very expensive.The results below are obtained by clearing the filters in the same example as in #9120