[DataGrid] Filtering performance: cache values #9284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
performance
component: data grid
Netlify deploy previewNetlify deploy preview: https://deploy-preview-9284--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
packages/grid/x-data-grid/src/hooks/features/filter/gridFilterUtils.ts
Outdated
Show resolved
Hide resolved
cherniavskii
approved these changes
Jun 12, 2023
|
I have pushed a master merge commit to this branch to trigger Argos CI, but it's not reflected in the PR 🤔 Do I miss something or is there something wrong with GitHub? |
cherniavskii
added
the
feature: Filtering
MBilalShafi
approved these changes
Jun 13, 2023
packages/grid/x-data-grid/src/hooks/features/filter/gridFilterUtils.ts
Outdated
Show resolved
Hide resolved
packages/grid/x-data-grid/src/hooks/features/filter/useGridFilter.tsx
Outdated
Show resolved
Hide resolved
… into perf-filtering-cache-values
Janpot
reviewed
Jun 14, 2023
| @@ -295,36 +295,44 @@ export const buildAggregatedFilterApplier = ( | |||
| }); | |||
| }; | |||
|
|
|||
| const isNotNull = <T>(result: null | T): result is T => result != null; | |||
There was a problem hiding this comment.
This would make it work for type checking at well
Suggested change
| const isNotNull = <T>(result: null | T): result is T => result != null; | |
| const isNotNull = <T>(result: T): result is NonNullable<T> => result != null; |
Not the most important, but it just caught my eye
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies point 2 of #9120.