Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support duplication of queries #1172

Closed
2 tasks done
Tracked by #437
prakhargupta1 opened this issue Oct 18, 2022 · 1 comment · Fixed by #1229
Closed
2 tasks done
Tracked by #437

Support duplication of queries #1172

prakhargupta1 opened this issue Oct 18, 2022 · 1 comment · Fixed by #1229
Assignees
@Janpot
Labels
feature: Queries Making new API requests scope: toolpad-studio Abbreviated to "studio"

Comments

@prakhargupta1
Copy link
Member

prakhargupta1 commented Oct 18, 2022 •
edited
Loading

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

An app may involve copying a query.
Just like duplicating a component we should support duplicating queries.

For now, the scope of duplication will be limited to the app. Later on we can support Global queries/copying queries from 1 app to the other.

  1. Show a duplicate button just like we show components
  2. Naming of the query?
  3. How to show duplicate button?

Examples 🌈

No response

Motivation 🔦

No response
@prakhargupta1 prakhargupta1 added the feature: Queries Making new API requests label Oct 18, 2022
This was referenced Oct 18, 2022
Closed
Closed
@prakhargupta1 prakhargupta1 mentioned this issue Oct 19, 2022
Closed
2 tasks
@oliviertassinari oliviertassinari changed the title Duplicating queries should be allowed Support duplication of queries Oct 19, 2022
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 19, 2022 •
edited
Loading

Screenshot 2022-10-19 at 12 15 12

@prakhargupta1 I have updated the issue title, I think that we should use the active voice as much as possible. It makes: what the issue is about clearer, close to the PR titles that will solve the issue, and match https://www.notion.so/mui-org/Style-guide-2a957a4168a54d47b14bae026d06a24b#c7c030728d7142cd8275617ddb1f38f2.

@Janpot Janpot self-assigned this Oct 25, 2022
This was referenced Oct 25, 2022
Merged
Merged
@oliviertassinari oliviertassinari added the scope: toolpad-studio Abbreviated to "studio" label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Janpot Janpot

Labels
feature: Queries Making new API requests scope: toolpad-studio Abbreviated to "studio"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support duplicating queries mui/toolpad
3 participants
@Janpot @oliviertassinari @prakhargupta1