Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataGrid height UX issues #1277

Closed
2 tasks done
Janpot opened this issue Nov 4, 2022 · 3 comments · Fixed by #1641
Closed
2 tasks done

DataGrid height UX issues #1277

Janpot opened this issue Nov 4, 2022 · 3 comments · Fixed by #1641
Assignees
@apedroferreira
Labels
bug 🐛 Something doesn't work feature: Components Button, input, table, etc. scope: toolpad-studio Abbreviated to "studio"
Milestone
Toolpad Core MVP

Comments

@Janpot
Copy link
Member

Janpot commented Nov 4, 2022 •
edited
Loading

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

DataGrid height

  • can go below 0 => type definitions: add min, max and restrict the number inputs to these.
  • doesn't update in component editor when edited through the drag handle

Current behavior 😯

Screen.Recording.2022-11-04.at.11.26.19.mov

Context

Related #1614
@Janpot Janpot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer bug 🐛 Something doesn't work feature: Components Button, input, table, etc. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 4, 2022
@apedroferreira
Copy link
Member

Yeah, also the whole current implementation of vertical resizing is a bit limited and temporary, it should be improved along with the upcoming improvements to the resizing UX.

@prakhargupta1
Copy link
Member

A user shared this feedback about the height of datagrid:

Is it just a straight html "height" attribute?

If yes, should such props be separate?

@Janpot
Copy link
Member Author

Janpot commented Jan 4, 2023

The prop shouldn't be there, we don't expose layout properties

@prakhargupta1 prakhargupta1 added this to the pro-code milestone Feb 2, 2023
@apedroferreira apedroferreira self-assigned this Feb 3, 2023
@apedroferreira apedroferreira mentioned this issue Feb 8, 2023
Merged
@oliviertassinari oliviertassinari added the scope: toolpad-studio Abbreviated to "studio" label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apedroferreira apedroferreira

Labels
bug 🐛 Something doesn't work feature: Components Button, input, table, etc. scope: toolpad-studio Abbreviated to "studio"
Projects
None yet
Milestone
Toolpad Core MVP
Development

Successfully merging a pull request may close this issue.

Hide resizable height prop controls mui/toolpad
4 participants
@Janpot @oliviertassinari @apedroferreira @prakhargupta1