Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[studio] Maximum request body size / 413 Payload Too Large #3902

Closed
oliviertassinari opened this issue Aug 7, 2024 · 2 comments · Fixed by #3903
Closed

[studio] Maximum request body size / 413 Payload Too Large #3902

oliviertassinari opened this issue Aug 7, 2024 · 2 comments · Fixed by #3903
Labels
scope: toolpad-studio Abbreviated to "studio"

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 7, 2024

Steps to reproduce

Steps:

  1. Call a backend function with a payload of 630 KB

Current behavior

SCR-20240807-mpoa

Expected behavior

No response

Context

I'm trying to use #1537 to improve https://www.notion.so/mui-org/DES-d648e13aa0c1468fa78622882dac6364. Tina @TinaDein is struggling to pull the latest changes from git. So I thought maybe I could create a quick Toolpad app for it.

SCR-20240807-mzan

Now, the problem seems to be that in

https://github.com/mui/mui-toolpad/blob/0112499a6ae22422c6ed6ddf8545616d9aaae35e/packages/toolpad-studio/src/server/rpc.ts#L57

we use the default limit value: https://expressjs.com/en/resources/middleware/body-parser.html#bodyparserjsonoptions, which is '100kb'.

In Retool: https://docs.retool.com/apps/guides/components/special-inputs/file-inputs

The maximum size for uploaded files is 40MB.

The alternative is to use Toolpad Core for this, but it's not really a point yet where is ready to be used as I understand it.

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: -

@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer scope: toolpad-studio Abbreviated to "studio" labels Aug 7, 2024
@Janpot Janpot added good first issue Great for first contributions. Enable to learn the contribution process. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer good first issue Great for first contributions. Enable to learn the contribution process. labels Aug 7, 2024
@Janpot
Copy link
Member

Janpot commented Aug 7, 2024

Can you try with https://pkg.csb.dev/mui/mui-toolpad/commit/4f952f42/@toolpad/studio? I've put it at 50 Mb.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 7, 2024

He's happy:

SCR-20240807-nswa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: toolpad-studio Abbreviated to "studio"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants