Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form for users to submit missing Marathi words for EXISTING English words #66

Open
sanketgarade opened this issue Aug 9, 2021 · 11 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sanketgarade
Copy link
Contributor

  • There are some words in the database where English word is present but the Marathi word is absent.
  • For such missing Marathi words, we can have a page where all the English words are displayed along with a text box beside it (to enter the missing Marathi word) and press a submit button at the top or bottom of the page to submit the words to the database.
  • These user submitted words will be collected in another database and will enter the main database upon review.
@masonwoodford
Copy link
Contributor

I could work on this, you want the logic to be implemented in .md?

@sanketgarade
Copy link
Contributor Author

sanketgarade commented Sep 4, 2021

Hi @masonwoodford

Can you tell how to plan to do this first? Especially the database part - which database file will be used? Where will it be located (in this repo or an external site?) and how words will be added to it?

And good to see you here again 😄

@masonwoodford
Copy link
Contributor

Same to you, I have to look into it a bit but could the words not just be stored in another csv file? I'm thinking the logic for submission would make the most sense in html/js files, similar to the ones found in the docs folder.

@sanketgarade
Copy link
Contributor Author

could the words not just be stored in another csv file?

I'm not sure it is possible to modify a csv file stored in the GitHub repo. But you can try. If it works then great. 😊

@sanketgarade
Copy link
Contributor Author

sanketgarade commented Sep 4, 2021

@masonwoodford you can also go through the conversation at #25. The benefits of having external database and limitation of GitHub pages as a static site is discussed there.

Though this (the search functionality, not the missing words addition) is being worked upon currently using external database, it is going on at a slow pace. So if your above alternative solution works, we can put that to use.

@sanketgarade
Copy link
Contributor Author

Hey 👋🏼 @masonwoodford

I didn't hear from you. Have you started working on this?

@masonwoodford
Copy link
Contributor

Haven't started on this yet, was a bit busier than anticipated this week, sorry. Will start on this later tonight!

@masonwoodford
Copy link
Contributor

I have the missing words sorted out, but I see the problem now, no way to allow users to add to the definitions.

@sanketgarade
Copy link
Contributor Author

I have the missing words sorted out, but I see the problem now, no way to allow users to add to the definitions.

Yes exactly.

  • For that the database (the csv file) which you wish to write to needs to be on some external website which allows writing to the database.
  • Once a user on our website enters the missing words and clicks the "Submit" button then a script on our webpage should run and add that word to this external database.

If you are willing to try such a solution let me know.

@masonwoodford
Copy link
Contributor

I'm not too familiar with the best way to set up something like that, to be honest. 😅

@sanketgarade
Copy link
Contributor Author

No problem. I have some other tasks/ideas in my head that I'll put in the issues sometime. Looking forward to your help there, if possible. 😃

Thanks again 😊

@sanketgarade sanketgarade added enhancement New feature or request help wanted Extra attention is needed labels Sep 30, 2021
@sanketgarade sanketgarade changed the title Form for users to submit missing Marathi words for existing English words Form for users to submit missing Marathi words for EXISTING English words Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants