Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.7 no longer succeeds on macOS #307

Closed
pinkwah opened this issue Feb 17, 2020 · 4 comments
Closed

Python 2.7 no longer succeeds on macOS #307

pinkwah opened this issue Feb 17, 2020 · 4 comments

Comments

@pinkwah
Copy link

pinkwah commented Feb 17, 2020

Homebrew has removed the flask for 2.7 some time ago (Homebrew/homebrew-core#49796) and now macOS builds are failing because they're trying to use the system python.

Is there any reason to keep this version around? Suggest to remove 2.7 examples from readme.

@mattip
Copy link
Collaborator

mattip commented Feb 17, 2020

I could not find where this repo is using brew to install CPython. The install_mac_cpython function uses curl and installer to download CPython from python.org. Which builds are failing?

This repo is used by many projects to build wheels which are then uploaded to PyPI, so the question "is python2.7 needed" becomes "is python2.7 needed to create PyPI wheels". The latest PyPI download statistics, as discussed on a python forum show that as far as PyPI goes, python2.7 is still very alive.

@pinkwah
Copy link
Author

pinkwah commented Feb 20, 2020

I have created an example which fails on 2.7 but not 3.7:

Repo: https://github.com/dotfloat/multibuild-py2
Travis: https://travis-ci.org/dotfloat/multibuild-py2

Python 2.7 build is failing with:

multibuild/osx_utils.sh: line 398: delocate-wheel: command not found

@matthew-brett
Copy link
Collaborator

I think this one is fixed now after @gaborbernat's very efficient work in finding / fixing the problem and making a new release of virtualenv, over at pypa/virtualenv#1641. Can you confirm this works for your build?

@pinkwah
Copy link
Author

pinkwah commented Feb 22, 2020

The build passes. Thanks!

@pinkwah pinkwah closed this as completed Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants