Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define DNS and WebRTC Direct formats + gomod support #1

Merged
merged 8 commits into from
Feb 27, 2019
Merged

Define DNS and WebRTC Direct formats + gomod support #1

merged 8 commits into from
Feb 27, 2019

Conversation

raulk
Copy link
Member

@raulk raulk commented Feb 27, 2019 •
edited
Loading

Carried over from whyrusleeping/mafmt#14 with refinements. Additionally:

  • Adds gomod support.
  • Adds HTTP(S) tests.
  • Fixes a bad HTTP pattern from the original PR (ported over from js-mafmt).

NOTE: merge #4 first.

Kubuxu
Kubuxu reviewed Feb 27, 2019
View reviewed changes
patterns.go Outdated Show resolved Hide resolved
Kubuxu
Kubuxu reviewed Feb 27, 2019
View reviewed changes
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTP pattern is not tested.

@raulk
Copy link
Member Author

raulk commented Feb 27, 2019

@Kubuxu I filed a PR to tidy up the tests before I touched them: #4.

@raulk raulk changed the title Define dns and WebRTC Direct formats Define DNS and WebRTC Direct formats + gomod support Feb 27, 2019
@raulk raulk force-pushed the feat/dns-webrtc-direct branch from 81330db to 5a5942b Compare February 27, 2019 18:00
Kubuxu
Kubuxu reviewed Feb 27, 2019
View reviewed changes
patterns_test.go Outdated Show resolved Hide resolved
Kubuxu
Kubuxu reviewed Feb 27, 2019
View reviewed changes
patterns_test.go Outdated Show resolved Hide resolved
@raulk raulk force-pushed the feat/dns-webrtc-direct branch from e393966 to 3b4f86d Compare February 27, 2019 18:17
@raulk raulk force-pushed the feat/dns-webrtc-direct branch from 3b4f86d to 08b1b5e Compare February 27, 2019 18:19
@raulk raulk requested a review from Kubuxu February 27, 2019 18:21
@raulk raulk force-pushed the feat/dns-webrtc-direct branch from 950462c to 896bfff Compare February 27, 2019 18:54
@raulk raulk merged commit 4d24f0d into master Feb 27, 2019
@raulk raulk deleted the feat/dns-webrtc-direct branch February 27, 2019 19:06
@Stebalien Stebalien mentioned this pull request Mar 13, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raulk @Kubuxu @backkem