add component/foreach helpers #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `Component` helper type and a `ForEach` helper method. The first attempt used an interface but interfaces imply allocation. We really can't afford to allocate here.
Opinionated: Paths should start with /, dammit!
|
Note: this changes the behavior of paths. Rational:
|
raulk
previously approved these changes
Oct 2, 2018
| return []Protocol{c.protocol} | ||
| } | ||
|
|
||
| func (c *Component) Decapsulate(o Multiaddr) Multiaddr { |
There was a problem hiding this comment.
I guess Decapsulate doesn't make much sense in the context of a single component, so it becomes equivalent to a Filter operation, i.e. returns itself if there's a match?
There was a problem hiding this comment.
Basically. Personally, given the new SplitFunc, I'm not sure how useful decapsulate is in general.
component.go
Outdated
| // ForEach walks over the multiaddr, component by component. | ||
| // | ||
| // This function iterates over components *by value* to avoid allocating. | ||
| func ForEach(m Multiaddr, cb func(c Component) bool) { |
There was a problem hiding this comment.
Would it make sense to add a Filter function that returns the components for a given protocol?
There was a problem hiding this comment.
Not sure about filter but I'm adding SplitFirst, SplitLast, SplitFunc, etc. functions.
raulk
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
Componenthelper type and aForEachhelper method.The first attempt used an interface but interfaces imply allocation. We really
can't afford to allocate here.