This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
fix: support for identity multihash #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gozala
changed the title
vmx
approved these changes
Aug 9, 2019
| expect(cid0).to.have.property('codec', 'dag-pb') | ||
| expect(cid0).to.have.property('version', 0) | ||
| expect(cid0).to.have.property('multihash').that.eql(mh) | ||
| expect(cid0.toBaseEncodedString()).to.eql('161g3c') |
There was a problem hiding this comment.
FYI (this is not blocking a merge): you can also use toString() instead of toBaseEncodedString().
lidel
suggested changes
Jun 15, 2020
|
@lidel thanks for reminding me of this pull (was staring at it puzzled not remembering doing it at all. Then noticed it's from last August 😱) I'll resolve conflicts sometime today. |
|
It sadly needs another rebase. |
|
@vmx how do you mean? (CI is green, no conflicts) |
|
@lidel Oh sorry. I had "Rebase and merge" selected (from a previous merge) and then it shows "This branch cannot be rebased due to conflicts")
But other ways of merging work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92 exception being throw by CID constructor when identity multihash is used