Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(dev): bump aegir from 38.1.8 to 39.0.6 #152

Merged
merged 3 commits into from
May 15, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 10, 2023

Bumps aegir from 38.1.8 to 39.0.6.

Release notes

Sourced from aegir's releases.

v39.0.6

39.0.6 (2023-05-09)

Bug Fixes

  • Update required node version to node 18 and npm 8 (#1184) (b7ef86c)

v39.0.5

39.0.5 (2023-05-03)

Bug Fixes

  • downgrade @​semantic-release/npm to cjs version (#1253) (4b4b77b)

v39.0.4

39.0.4 (2023-05-03)

Bug Fixes

v39.0.3

39.0.3 (2023-04-27)

Dependencies

v39.0.2

39.0.2 (2023-04-27)

Bug Fixes

Dependencies

v39.0.1

39.0.1 (2023-04-27)

... (truncated)

Changelog

Sourced from aegir's changelog.

39.0.6 (2023-05-09)

Bug Fixes

  • Update required node version to node 18 and npm 8 (#1184) (b7ef86c)

39.0.5 (2023-05-03)

Bug Fixes

  • downgrade @​semantic-release/npm to cjs version (#1253) (4b4b77b)

39.0.4 (2023-05-03)

Bug Fixes

39.0.3 (2023-04-27)

Dependencies

39.0.2 (2023-04-27)

Bug Fixes

Dependencies

39.0.1 (2023-04-27)

Bug Fixes

Dependencies

... (truncated)

Commits
  • 716c6ee chore(release): 39.0.6 [skip ci]
  • b7ef86c fix: Update required node version to node 18 and npm 8 (#1184)
  • cf690fc chore(release): 39.0.5 [skip ci]
  • 4b4b77b fix: downgrade @​semantic-release/npm to cjs version (#1253)
  • d0749be chore(release): 39.0.4 [skip ci]
  • dd91980 fix: use semantic-release-monorepo fork (#1252)
  • 8acdfe9 chore(release): 39.0.3 [skip ci]
  • 07150fc deps: bump minimatch from 5.1.6 to 9.0.0 (#1232)
  • 584ceca deps: bump p-map from 5.5.0 to 6.0.0 (#1249)
  • f0be0fc chore(release): 39.0.2 [skip ci]
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [aegir](https://github.com/ipfs/aegir) from 38.1.8 to 39.0.6.
- [Release notes](https://github.com/ipfs/aegir/releases)
- [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md)
- [Commits](ipfs/aegir@v38.1.8...v39.0.6)

---
updated-dependencies:
- dependency-name: aegir
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 10, 2023
@achingbrain achingbrain merged commit 72bdf8e into master May 15, 2023
@achingbrain achingbrain deleted the dependabot/npm_and_yarn/aegir-39.0.6 branch May 15, 2023 08:16
github-actions bot pushed a commit that referenced this pull request May 15, 2023
## [12.1.2](v12.1.1...v12.1.2) (2023-05-15)

### Dependencies

* **dev:** bump aegir from 38.1.8 to 39.0.6 ([#152](#152)) ([72bdf8e](72bdf8e))
@github-actions
Copy link

🎉 This PR is included in version 12.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@staltz
Copy link

staltz commented May 15, 2023

Hi, we use js-mafmt as a transitive dependency in a project with nodejs-mobile (at 16.17.1), but this PR and js-mafmt 12.1.2 broke our installation because of the engines: { node: ">=18.0.0" } requirement.

As far as I understand, updating aegir as a dev dep should not have an impact on this library's usage in runtime, so Node.js 16.x should technically still be able to run js-mafmt 12.1.2.

Could you relax the engine range?

@achingbrain
Copy link
Member

Aegir contains commands to align project config across the lib2p/ipld/multiformats/ipfs repos which is why this change was made here.

We only run tests on lts node (18.16.0 at the time of writing) so there's no guarantee this will continue to work on node 16.

npm normally just prints a warning message for non-compliant engines - do you have some strict validation turned on?

@staltz
Copy link

staltz commented May 15, 2023

We are using yarn, with no special configurations, so this seems to be the default behavior with yarn.

I understand the alignment argument. However, considering that this was an actual breaking change in our project, could the version of this library have reflected that on major num instead of the patch num?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants