-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(dev): bump aegir from 38.1.8 to 39.0.6 #152
Conversation
Bumps [aegir](https://github.com/ipfs/aegir) from 38.1.8 to 39.0.6. - [Release notes](https://github.com/ipfs/aegir/releases) - [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md) - [Commits](ipfs/aegir@v38.1.8...v39.0.6) --- updated-dependencies: - dependency-name: aegir dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
## [12.1.2](v12.1.1...v12.1.2) (2023-05-15) ### Dependencies * **dev:** bump aegir from 38.1.8 to 39.0.6 ([#152](#152)) ([72bdf8e](72bdf8e))
🎉 This PR is included in version 12.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi, we use js-mafmt as a transitive dependency in a project with nodejs-mobile (at 16.17.1), but this PR and js-mafmt 12.1.2 broke our installation because of the As far as I understand, updating aegir as a dev dep should not have an impact on this library's usage in runtime, so Node.js 16.x should technically still be able to run js-mafmt 12.1.2. Could you relax the engine range? |
Aegir contains commands to align project config across the lib2p/ipld/multiformats/ipfs repos which is why this change was made here. We only run tests on lts node (18.16.0 at the time of writing) so there's no guarantee this will continue to work on node 16. npm normally just prints a warning message for non-compliant engines - do you have some strict validation turned on? |
We are using yarn, with no special configurations, so this seems to be the default behavior with yarn. I understand the alignment argument. However, considering that this was an actual breaking change in our project, could the version of this library have reflected that on major num instead of the patch num? |
Bumps aegir from 38.1.8 to 39.0.6.
Release notes
Sourced from aegir's releases.
... (truncated)
Changelog
Sourced from aegir's changelog.
... (truncated)
Commits
716c6ee
chore(release): 39.0.6 [skip ci]b7ef86c
fix: Update required node version to node 18 and npm 8 (#1184)cf690fc
chore(release): 39.0.5 [skip ci]4b4b77b
fix: downgrade@semantic-release/npm
to cjs version (#1253)d0749be
chore(release): 39.0.4 [skip ci]dd91980
fix: use semantic-release-monorepo fork (#1252)8acdfe9
chore(release): 39.0.3 [skip ci]07150fc
deps: bump minimatch from 5.1.6 to 9.0.0 (#1232)584ceca
deps: bump p-map from 5.5.0 to 6.0.0 (#1249)f0be0fc
chore(release): 39.0.2 [skip ci]Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)