This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
feat: add many sha3 functions #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
approved these changes
Jan 2, 2018
|
Thanks @hacdias :) |
|
Do you think we should add more tests? @diasdavid |
|
increasing test coverage is always important. One interesting thing to do is to add tests to https://github.com/multiformats/js-multihashing-async (which is the one used throughout IPFS) that compare multihashing to multihashing-async output to ensure everything is correct. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14.
Still missing tests.