Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Multicodec Implementation #112

Open
AliabbasMerchant opened this issue Jan 17, 2019 · 8 comments · May be fixed by #143
Open

Java Multicodec Implementation #112

AliabbasMerchant opened this issue Jan 17, 2019 · 8 comments · May be fixed by #143

Comments

@AliabbasMerchant
Copy link

AliabbasMerchant commented Jan 17, 2019

Hello!
I have started working on the Java Implementation of Multicodec: https://github.com/AliabbasMerchant/java-multicodec
Tagging @ianopolous

@ianopolous
Copy link
Member

Thanks for the tag. Is this different from the Codec in Cid? Where would it be used?
https://github.com/ipld/java-cid/blob/master/src/main/java/io/ipfs/cid/Cid.java

@AliabbasMerchant
Copy link
Author

AliabbasMerchant commented Jan 27, 2019

This is similar to py-multicodec.

It contains all multicodecs, as defined in this repo, and not just CIDs.

Also, I am nearly done with the code.
I'll hopefully commit it by tomorrow.

@AliabbasMerchant
Copy link
Author

I am done with the code and the tests and have commited the code: https://github.com/AliabbasMerchant/java-multicodec
It is working properly. I have cross-checked with py-multicodec.
Please just have a look and let me know. I will start writing the docs once I get a confirmation from you guys.
Tagging: @ianopolous @daviddias @kumavis @RichardLitt @jbenet

@AliabbasMerchant
Copy link
Author

I am done with the documentation.
1 request: Could someone please check the pom.xml and build.xml files?? I have made modifications, as far as I could, but I am not confident. There is indeed some error in the build.xml (https://github.com/AliabbasMerchant/java-multicodec/blob/5e44c90aeacecde66e6f4f3fa11b7d0bfd3ab819/build.xml#L40)

Also, what about the maven hosting and all?? I don't know a thing about it.

Again, Tagging: @ianopolous @daviddias @kumavis @RichardLitt @jbenet

Thank you guys in advance.

@AliabbasMerchant
Copy link
Author

@ianopolous @daviddias @kumavis @RichardLitt @jbenet ??
Guys please have a look at the repo and respond... 😃

@RichardLitt
Copy link
Member

Sorry @AliabbasMerchant, I'm not involved in this project anymore, and can't help at the moment. Good luck!

@AliabbasMerchant
Copy link
Author

@RichardLitt Oh Ok.
Although, 1 request, could you please tell the concerned guys... Or @mention them...??
Thank you...

@RichardLitt
Copy link
Member

I appreciate that you're eager to resolve this. But I just mentioned that I'm not involved. They'll get to it when they get to it; there's not much more I'm willing to do on my end. Again, good luck.

@AliabbasMerchant AliabbasMerchant changed the title [WIP] Java Multicodec Implementation Java Multicodec Implementation Jul 29, 2019
@AliabbasMerchant AliabbasMerchant linked a pull request Jul 29, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@ianopolous @RichardLitt @AliabbasMerchant and others