Refactor construction API #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server/services/common.go
Outdated
| } | ||
|
|
||
| func isZeroAmount(amount string) bool { | ||
| return amount == "" || amount == "0" || amount == "-0" |
There was a problem hiding this comment.
what about "0.0"? or "00". Do we have a more robust way to find out that we cover all these cases?
There was a problem hiding this comment.
Right, added a more robust solution - for integers, though (decimal numbers do not need to be handled - at least, not yet).
| return errors.New("missing metadata: 'gasPrice'") | ||
| } | ||
| if metadata.Version != 1 { | ||
| return errors.New("bad metadata: unexpected 'version'") |
There was a problem hiding this comment.
maybe
return fmt.Errorf("bad metadata: unexpected 'version' %v", metadata.Version)There was a problem hiding this comment.
Indeed, fixed.
bogdan-rosianu
approved these changes
Oct 11, 2022
iulianpascalau
approved these changes
Oct 11, 2022
|
|
||
| value, ok := big.NewInt(0).SetString(amount, 10) | ||
| if ok { | ||
| return value.Sign() == 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.4.14,maxFeeandfeeMultiplierdo not exist anymore. See: [preprocess]remove max_fee and mulltiplier in preprocess request coinbase/mesh-specifications#110, [types]remove two fields in preprocess request coinbase/mesh-sdk-go#439