Workaround (quick fix) to support construction of cross-shard transactions #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
commented
Oct 5, 2022
| if len(operations) > 1 { | ||
| options["value"] = operations[1].Amount.Value | ||
| } else { | ||
| options["value"] = strings.Trim(operations[0].Amount.Value, "-") |
There was a problem hiding this comment.
This is a temporary workaround - will be refactored in #51.
andreibancioiu
commented
Oct 5, 2022
| options["sender"] = operations[0].Account.Address | ||
|
|
||
| if metadata["receiver"] != nil { | ||
| options["receiver"] = metadata["receiver"] |
There was a problem hiding this comment.
The receiver from the metadata takes priority.
andreibancioiu
commented
Oct 5, 2022
| } | ||
|
|
||
| if metadata["value"] != nil { | ||
| options["value"] = metadata["value"] |
There was a problem hiding this comment.
The value from the metadata takes priority.
miiu96
approved these changes
Oct 5, 2022
bogdan-rosianu
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for constructing cross-shard transactions - handle
receiverandvaluefrom the preprocess metadata, when they are present.Related to: multiversx/mx-chain-rosetta-checks#7
The construction API will be partly refactored in #51.