From 2a46dafb5875df942232feb78e5a38316cf6c9ec Mon Sep 17 00:00:00 2001
From: Alexandru Popenta <alexandru.p9913@gmail.com>
Date: Thu, 4 Jul 2024 10:35:27 +0300
Subject: [PATCH] very small refactoring

---
 .../smartContractTransactionsFactory.ts                   | 4 +---
 src/transactionsFactories/transferTransactionsFactory.ts  | 8 +++++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/transactionsFactories/smartContractTransactionsFactory.ts b/src/transactionsFactories/smartContractTransactionsFactory.ts
index fad68afd..6102ebac 100644
--- a/src/transactionsFactories/smartContractTransactionsFactory.ts
+++ b/src/transactionsFactories/smartContractTransactionsFactory.ts
@@ -96,9 +96,7 @@ export class SmartContractTransactionsFactory {
         let numberOfTokens = tokenTransfers.length;
 
         if (nativeTransferAmount && numberOfTokens) {
-            const nativeTransfer = TokenTransfer.newFromEgldAmount(nativeTransferAmount);
-            tokenTransfers.push(nativeTransfer);
-
+            tokenTransfers.push(TokenTransfer.newFromEgldAmount(nativeTransferAmount));
             nativeTransferAmount = 0n;
             numberOfTokens++;
         }
diff --git a/src/transactionsFactories/transferTransactionsFactory.ts b/src/transactionsFactories/transferTransactionsFactory.ts
index 74249aa3..68eacac9 100644
--- a/src/transactionsFactories/transferTransactionsFactory.ts
+++ b/src/transactionsFactories/transferTransactionsFactory.ts
@@ -155,7 +155,7 @@ export class TransferTransactionsFactory {
         let tokenTransfers = options.tokenTransfers ? [...options.tokenTransfers] : [];
         const numberOfTokens = tokenTransfers.length;
 
-        if (!nativeAmount && !numberOfTokens) {
+        if (!nativeAmount && numberOfTokens === 0) {
             throw new ErrBadUsage("No native token amount or token transfers provided");
         }
 
@@ -163,7 +163,7 @@ export class TransferTransactionsFactory {
             throw new ErrBadUsage("Can't set data field when sending esdt tokens");
         }
 
-        if (nativeAmount && !tokenTransfers) {
+        if (nativeAmount && numberOfTokens === 0) {
             return this.createTransactionForNativeTokenTransfer({
                 sender: options.sender,
                 receiver: options.receiver,
@@ -173,7 +173,9 @@ export class TransferTransactionsFactory {
         }
 
         const nativeTransfer = nativeAmount ? TokenTransfer.newFromEgldAmount(nativeAmount) : undefined;
-        nativeTransfer ? tokenTransfers.push(nativeTransfer) : null;
+        if (nativeTransfer) {
+            tokenTransfers.push(nativeTransfer);
+        }
 
         return this.createTransactionForESDTTokenTransfer({
             sender: options.sender,