Allow PixelEditor to be loaded with a PHAsset #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muukii
reviewed
Jan 7, 2020
| return loadingView != nil | ||
| } | ||
| set { | ||
| if newValue, self.isLoading == false { |
There was a problem hiding this comment.
I think it would be better to create UI component with separating code to get better management.
Would you mind if I improve this code when I get time?
muukii
reviewed
Jan 7, 2020
| } | ||
| private let asset: PHAsset? | ||
| private var loadingView: [UIView]? | ||
| private var imageSource: ImageSource? |
There was a problem hiding this comment.
If it's possible, we would like to avoid having imageSource here directly.
muukii
reviewed
Jan 7, 2020
muukii
reviewed
Jan 8, 2020
| @@ -60,10 +60,6 @@ open class ImageScrollView: UIScrollView { | |||
| initialize() | |||
| } | |||
|
|
|||
| deinit { | |||
| NotificationCenter.default.removeObserver(self) | |||
|
|
||
| import UIKit | ||
|
|
||
| class LoadingView: UIView { |
There was a problem hiding this comment.
IMO: I usually add the final attribute when we need to create a subclass.
Comment on lines
360
to
386
| private func downloadAssetIfNeeded() { | ||
| guard let asset = self.asset else { return } | ||
| let previewRequestOptions = PHImageRequestOptions() | ||
| previewRequestOptions.deliveryMode = .highQualityFormat | ||
| previewRequestOptions.isNetworkAccessAllowed = true | ||
| previewRequestOptions.version = .current | ||
| previewRequestOptions.resizeMode = .fast | ||
| let finalImageRequestOptions = PHImageRequestOptions() | ||
| finalImageRequestOptions.deliveryMode = .highQualityFormat | ||
| finalImageRequestOptions.isNetworkAccessAllowed = true | ||
| finalImageRequestOptions.version = .current | ||
| finalImageRequestOptions.resizeMode = .none | ||
| //TODO cancellation | ||
| PHImageManager.default().requestImage(for: asset, targetSize: CGSize(width: 360, height: 360), contentMode: .aspectFit, options: previewRequestOptions) { [weak self] (image, _) in | ||
| guard let image = image, let self = self, self.isLoading else { return } | ||
| self.replace(imageSource: .init(source: image)) | ||
| } | ||
| PHImageManager.default().requestImage(for: asset, targetSize: PHImageManagerMaximumSize, contentMode: .aspectFit, options: finalImageRequestOptions) { [weak self] (image, _) in | ||
| guard let self = self else { return } | ||
| if let image = image { | ||
| self.replace(imageSource: .init(source: image)) | ||
| self.isLoading = false | ||
| } else { | ||
| // TODO Error handleing | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
It might be good to do this on EditingStack.
muukii
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will add a few additional features soon, but I think this can be merged as is as soon as
AssetPickeris made public