Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Poster Image, Preview Thumbnail, and Time Display props #598

Merged
merged 5 commits into from
May 11, 2023

Conversation

AdamJaggard
Copy link
Contributor

Adds missing props for Poster Image, Preview Thumbnail, and Time Display components.

@AdamJaggard AdamJaggard requested review from a team and heff as code owners May 11, 2023 14:56
@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 7:50pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 7:50pm

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #598 (196aaec) into main (14156f7) will decrease coverage by 0.07%.
The diff coverage is 63.91%.

❗ Current head 196aaec differs from pull request most recent head 2f2b3cc. Consider uploading reports for the commit 2f2b3cc to get more accurate results

@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   77.93%   77.86%   -0.07%     
==========================================
  Files          43       43              
  Lines        7600     7676      +76     
==========================================
+ Hits         5923     5977      +54     
- Misses       1677     1699      +22     
Impacted Files Coverage Δ
src/js/media-preview-thumbnail.js 63.29% <56.60%> (+1.04%) ⬆️
src/js/media-poster-image.js 68.42% <70.37%> (+1.38%) ⬆️
src/js/media-preview-time-display.js 83.01% <76.47%> (-3.47%) ⬇️

}

/**
* @type {Array<number> | undefined} Fixed length array [x, y, width, height] or undefined
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick(non-blocking): This should probably be [number, number, number, number] | undefined since it's a tuple

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially did this and typescript didn't like the return type because I could be technically returning an array of any length. Although I guess I could add a type comment to the return to force it?

Copy link
Collaborator

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄‍♂️

Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needs that TS fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants