-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Poster Image, Preview Thumbnail, and Time Display props #598
feat: Poster Image, Preview Thumbnail, and Time Display props #598
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #598 +/- ##
==========================================
- Coverage 77.93% 77.86% -0.07%
==========================================
Files 43 43
Lines 7600 7676 +76
==========================================
+ Hits 5923 5977 +54
- Misses 1677 1699 +22
|
} | ||
|
||
/** | ||
* @type {Array<number> | undefined} Fixed length array [x, y, width, height] or undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick(non-blocking): This should probably be [number, number, number, number] | undefined
since it's a tuple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially did this and typescript didn't like the return type because I could be technically returning an array of any length. Although I guess I could add a type comment to the return to force it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏄♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just needs that TS fix
Adds missing props for Poster Image, Preview Thumbnail, and Time Display components.