Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook Types #303

Closed
shellscape opened this issue Jul 21, 2023 · 4 comments
Closed

Webhook Types #303

shellscape opened this issue Jul 21, 2023 · 4 comments

Comments

@shellscape
Copy link

I was really hopeful that Mux was going to have a robust JS package with types, given how well-refined the overall product is. Sadly disappointed that types are so sparse, while the footprint of the Mux API and Webhook payloads are so wide. For instance: https://docs.mux.com/webhook-reference#video.asset.ready - the payload there is massive. Leaving it up to the consumer to properly type based on JSON documentation is not the best DX. Would love to see Mux improve and put additional effort into DX.

@dylanjha
Copy link
Collaborator

Thanks @shellscape , we're actually in the process of re-vamping a newly created Node SDK that has a number of enhancements. Let me check if the webhook types is in scope for that.

This is definitely an understandable pain point that we would like to improve!

@foureight84
Copy link

Do you have a tentative release date for this revamped SDK? I'm hoping it would also address import issues as well in Typescript.

@TikiCat7
Copy link

also wondering if there is any update regarding webhook types :)

@dylanjha
Copy link
Collaborator

This as been done in version 8, the webhook types, import issues and better Types all around:

stainless-app bot pushed a commit that referenced this issue Aug 27, 2024
* Draft changes

* detabbify

* Address Phil's review comments
stainless-app bot added a commit that referenced this issue Aug 27, 2024
* Draft changes

* detabbify

* Address Phil's review comments
stainless-app bot pushed a commit that referenced this issue Sep 5, 2024
* Draft changes

* detabbify

* Address Phil's review comments
jsanford8 added a commit that referenced this issue Nov 15, 2024
* feat(api): remove sunsetted spaces webhooks

* chore: rebuild project due to codegen change (#432)

* feat(api): OpenAPI spec update via Stainless API (#433)

* feat(api): OpenAPI spec update via Stainless API (#434)

* chore(internal): minor reformatting (#435)

* feat(api): manual updates (#436)

* chore: gitignore test server logs (#437)

* chore: rebuild project due to codegen change (#439)

* chore(api): remove Spaces (#440)

* feat(api): generate webhook types (#441)

* feat(api): make webhooks a standalone api (#442)

* chore: rebuild project due to codegen change (#444)

* chore: rebuild project due to codegen change (#447)

* feat(api): OpenAPI spec update via Stainless API (#448)

* chore: rebuild project due to codegen change (#449)

* chore: rebuild project due to codegen change (#450)

* chore: rebuild project due to codegen change (#452)

* chore: rebuild project due to codegen change (#454)

* chore: rebuild project due to codegen change (#455)

* chore: rebuild project due to codegen change (#456)

* chore(tests): update prism version (#457)

* fix: use relative paths (#458)

* feat(api): OpenAPI spec update via Stainless API (#459)

* fix(compat): remove ReadableStream polyfill redundant since node v16 (#460)

Note that this breaks streaming in Node v14, which has been unsupported since v4.0.0 of this library.

* chore(docs): fix incorrect client var names (#461)

* chore(internal): add constant for default timeout (#463)

* chore(ci): correctly tag pre-release npm packages (#464)

* chore: rebuild project due to codegen change (#465)

* chore: force eslint to use non flat config (#466)

* chore(ci): minor changes (#467)

* chore(ci): bump prism mock server version (#468)

* chore(examples): minor formatting changes (#469)

* chore: rebuild project due to codegen change (#470)

* [video] video_quality as a replacement for encoding_tier (#303)
 (#472)


* Draft changes

* detabbify

* Address Phil's review comments

* chore(ci): check for build errors (#473)

* chore: run tsc as part of lint script (#474)

* chore: replace encoding tiers with video quality levels (#475)

* chore(ci): install deps via ./script/bootstrap (#476)

* fix(client): correct File construction from node-fetch Responses (#478)

* chore(internal): dependency updates (#479)

* chore(internal): minor bump qs version (#480)

* chore: revert jose removal

* fix(uploads): avoid making redundant memory copies (#483)

* fix file permissions

* chore(internal): codegen related update (#484)

* chore(internal): codegen related update (#485)

* fix(errors): pass message through to APIConnectionError (#486)

* chore: better object fallback behaviour for casting errors (#487)

* docs: update CONTRIBUTING.md (#488)

* chore(internal): add dev dependency (#489)

* chore(internal): fix some types (#491)

* fix(types): remove leftover polyfill usage (#492)

* feat(client): send retry count header (#493)

* chore(internal): codegen related update (#494)

* feat(api): api update (#495)

* feat(api): api update (#497)

* feat(api): api update (#500)

* feat(api): api update (#501)

* feat(api): api update (#502)

* chore: rebuild project due to codegen change (#507)

* chore: rebuild project due to codegen change (#508)

* feat(api): api update (#509)

* feat(api): api update (#510)

* chore: rebuild project due to codegen change (#511)

* chore: rebuild project due to codegen change (#513)

* chore: rebuild project due to codegen change (#514)

* chore: rebuild project due to codegen change (#515)

* Generate multiple tokens with one `signPlaybackId` call (#499)

* Generate multiple tokens with one `signPlaybackId` call

* Add missing DataTypeClaim

* wait, I thought of a better signature

* Revert "wait, I thought of a better signature"

This reverts commit 5fdefba.

* fix: ensure config for signPlaybackId can be optional (#516)

* chore: rebuild project due to codegen change (#517)

* chore: rebuild project due to codegen change (#518)

* release: 9.0.0

* update changelog

---------

Co-authored-by: meorphis <meorphis@gmail.com>
Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com>
Co-authored-by: Stainless Bot <dev+git@stainlessapi.com>
Co-authored-by: Young-Jin Park <youngjinpark20@gmail.com>
Co-authored-by: Darius Cepulis <dcepulis@mux.com>
Co-authored-by: Justin Sanford <justin.h.sanford@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants