Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does this module use sjcl for sync randomBytes? #41

Open
ctavan opened this issue Feb 27, 2020 · 1 comment
Open

Why does this module use sjcl for sync randomBytes? #41

ctavan opened this issue Feb 27, 2020 · 1 comment

Comments

@ctavan
Copy link

ctavan commented Feb 27, 2020

Given the discussion at uuidjs/uuid#375 (comment) I was wondering why this module doesn't use the same approach as https://github.com/LinusU/react-native-get-random-values to provide a sync randomBytes() implementation but instead falls back to sjcl?

Is this just a legacy because the fact that it is possible to create sync react-native modules was little known before facebook/react-native#20686 or are there more profound reasons?

@mvayngrib
Copy link
Owner

Is this just a legacy because the fact that it is possible to create sync react-native modules was little known before facebook/react-native#20686

yep, you nailed it! PRs welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants