Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate nx to 15 #187

Closed
mvdicarlo opened this issue Sep 18, 2023 · 7 comments
Closed

Migrate nx to 15 #187

mvdicarlo opened this issue Sep 18, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@mvdicarlo
Copy link
Owner

Ensure that react and electron migrate to 15 successfully and build in exe without white screen.

@mvdicarlo mvdicarlo added the enhancement New feature or request label Sep 18, 2023
@leaftail1880
Copy link
Contributor

Would like to assign this to me.

@mvdicarlo mvdicarlo assigned mvdicarlo and leaftail1880 and unassigned mvdicarlo Sep 29, 2023
@mvdicarlo
Copy link
Owner Author

pleaase ensure nx-electron also gets updated

@mvdicarlo
Copy link
Owner Author

@leaftail1880 I had to revert your PR.
When it merged into main it was no longer able to build the ui portion.
I tested your branch before merging into main and it was fine, but something breaks when merging the two.

@leaftail1880
Copy link
Contributor

@mvdicarlo looks like main ovverided some package bumps. Ill look into it

@leaftail1880
Copy link
Contributor

leaftail1880 commented Oct 25, 2023

looked deeper into it. Original problem was related to caniuse lite, strict resolve of this module has helped. However, after running yarn start it does not shows icons. This is related to webpack dynamic import, or webpack version and/or plugins that have been changed after migrating and extracting managed webpack config to apps/postybirb-ui/webpack.config.js.

Requires a lot of digging.

@mvdicarlo
Copy link
Owner Author

https://github.com/mvdicarlo/postybirb/tree/users/mvdicarlo/v16
Created my own branch attempt and just pushed up to v16 and put in vite.
Just need to solve the whole dynamic import problem that exists because eui components use dynamic import svgs for whatever reason.

@leaftail1880
Copy link
Contributor

Dynamic icon importing is known issue and there is workarounds for that here

However, i need to manually mix your solution and mine because we both applied some pathes (for mine thats eslintrc changes and test fixes). I can do that after a week, most likely on 9th october

@github-project-automation github-project-automation bot moved this from In Progress to Done in PostyBirb Development Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants