Request Redraw only if really needed. Fixes #277 #278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I had this problem that I described at this issue:
where it is a blocker for my use case that
bevy_egui
sendsRequestRedraw
events, even when I'm not painting any EGUI window.So, this PR fixes the
process_output_system
so that it doesn't emit that event when nothing is being painted.It will keep working as usual when EGUI is painting.
On another note:
I'm not sure that
RequestRedraw
is really needed. If theUpdateMode
of the Bevy'sWinitSettings
resource isUpdateMode::Continuous
, Bevy will redraw anyway. If it isUpdateMode::Reactive
orUpdateMode::ReactiveLowPower
, both of them should answer to Window events, like moving the cursor (see here in bevy_winit)However, I'm not removing it in this PR to be cautious and not reintroduce previous bugs like