-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to bevy 0.15 #309
Update to bevy 0.15 #309
Conversation
src/lib.rs
Outdated
@@ -797,6 +798,8 @@ pub struct EguiContextQuery { | |||
pub render_target_size: &'static mut RenderTargetSize, | |||
/// [`Window`] component, when rendering to a window. | |||
pub window: Option<&'static mut Window>, | |||
/// Cursor for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfinished comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out!
It's part of an actually a non trivial change: The handling of the cursor is changed in bevy 0.15 ; in this PR I moved the initialization of the cursor to the user through configure_cursor
:
https://github.com/mvlabat/bevy_egui/blob/3be113b82f8b7122b33f92467d20d2560e0d7722/examples/ui.rs#L56-L60
But I think this code snippet should live with bevy_egui (or bevy_something 🤔 ; but in the meantime we should be able to add it if not present.)
Just brainstorming cursor handling. We can provide a system that is added by default that correctly sets CursorIcon for the window from the egui EguiCursorIcon value. But user could opt out: In this case it would be nice if egui would not set CursorIcon component directly. Probably this functionality could be added in a PR at later date. |
879a24b
to
8956b27
Compare
bevy pushed version 0.15.0-rc.1 |
Something is rendering! but still mostly broken.
|
Also relevant: bevyengine/bevy#16093. As a workaround we can always just enable the |
I implemented your suggestion by always enabling |
@Vrixyz huge thanks, as always! I've just updated it to the actual 0.15 release and merged. |
Currently testing on bevy 0.15 rc3.
custom_cursor
.