Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RGBW color saturation #16

Open
balert opened this issue Oct 10, 2017 · 2 comments
Open

RGBW color saturation #16

balert opened this issue Oct 10, 2017 · 2 comments
Labels
enhancement

Comments

@balert
Copy link

balert commented Oct 10, 2017

I've tried and successfully changed color saturation of my bulbs using the node-milight-promise library directly, i.e. my bulbs apparently support saturation control. As written in the readme, saturation control is not yet supported by this pimatic plugin, though. Is there some work in progress? I'd be willing to help ...
@balert
Copy link
Author

balert commented Oct 22, 2017

I've managed to get saturation working in a fork of this project (https://github.com/balert/pimatic-milight-reloaded).

@mwittig
Copy link
Owner

mwittig commented Oct 23, 2017 •
edited
Loading

That's great. I'll review your code as soon as I can. It'll take a a few days as I am currently very busy

EDIT: I have just quickly reviewed your code and I think some more work is need with regards to the "set saturation" action handler. I'll get back to this soon. Please also note, the "set color" action will also set saturation based on the result of the RGB to HSV transformation

@mwittig mwittig mentioned this issue Apr 17, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@balert @mwittig