-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Improvements #605
Comments
Definitely agree with using a rev since pre-commit won't auto update. You can also create a build matrix of different supported Python versions in the Github actions I believe. |
I still can't find how to run the actions when
I really want (1) because... my commits break the CI very often so I prefer to have the option to test them before making the pull request 😄 I've looked into https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows and https://git.luolix.topmunity/t/how-to-trigger-an-action-on-push-or-pull-request-but-not-both/ . The later is very similar to what I am looking for, however I also want to see the result of the CI when I push to a branch other than master. So unless someone has a better proposal, I'll go for the simple
|
To avoid run duplication, when pushing to master from an internal branch, I always use: on:
push:
branches: [master]
tags:
- '*'
pull_request: then if I'm working on another branch, you can always just create a draft PR to master, to have the CI run |
Also FYI, you can run |
Thank you @chrisjsewell !
Yes I know, this is going to create some duplication, but... ATM I do prefer that than having to create draft PR, because then every watcher is going to see how often my commits break the CI 😆 |
@chrisjsewell , if you don't mind I will not install pandoc on the pip CI. Doing so would... reduce the code coverage! Indeed we would have any environment left in without pandoc, and we would not test any more than Jupytext can work well without pandoc 😄 |
@chrisjsewell you're right, this duplication is a pain, I am trying to see if I can find another solution. |
The skip-duplicate-action seems to provide a satisfactory solution to the problem of duplicate runs... see how (exactly half) of the duplicate jobs were skipped at https://github.com/mwouts/jupytext/pull/633/checks ! |
Suggested by @chrisjsewell at #599, #601, #602
rev: 19.10b0
rather thanstable
forblack
in the pre-commit hookmwouts/jupytext
pandoc
in the pip CI using e.g.r-lib/actions/setup-pandoc
The text was updated successfully, but these errors were encountered: