Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EFS volumes if already exists #6

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

anthonymq
Copy link
Contributor

No description provided.

@mxab
Copy link
Owner

mxab commented Feb 20, 2024

Hi, thank you contributing to this project. Could you elaborate a bit more about all the changes

Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@anthonymq
Copy link
Contributor Author

Hi @mxab,
I'm using your spawner since we have a nomad cluster in production. I encountered an issue with AWS EFS volumes.
The AWS efs csi driver returns an error if a volume already exist which is pretty annoying.
This fix catches that error since creating a volume should not return an error if it already exist.

@mxab
Copy link
Owner

mxab commented Feb 29, 2024

Hi,
yes I guess this makes sense. Thank you for cleaning up the PR

@mxab mxab merged commit e91f521 into mxab:main Feb 29, 2024
2 of 3 checks passed
@mxab
Copy link
Owner

mxab commented Mar 1, 2024

It's released. Thanks for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants