Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return 202 when challenge in createAuthorization response #230

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

mcoburnmx
Copy link
Collaborator

Summary of Changes

Updated createAuthorization controller method to detect when a response contains a challenge and then sets the status code to 202. The motivation behind this change is that the client is wanting to support prompting the user to accept terms and conditions for Zelle before proceed to use the feature.

Fixes # HW2-1135

Public API Additions/Changes

Modified AuthorizationsController.createAuthorization() to detect challenge in response and alter status code to 202. No method signatures were changed.

Downstream Consumer Impact

This change should be transparent and should not impact downstream consumers.

How Has This Been Tested?

Tested it locally with a Path connector to verify getting back a 200 or 202 as desired. Also ran a project's authorization Arsenal tests against it to ensure they still passed.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@mcoburnmx mcoburnmx merged commit fc590a5 into master Jul 2, 2024
4 checks passed
@mcoburnmx mcoburnmx deleted the mpc/hw2-1135-2 branch July 2, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants