-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note for using within a Dialog #2
Comments
Thank you for your sharing the advice! Indeed, I encountered some issues nesting the |
nevermind, I cound fix my problem by adding a <div className="relative mt-2">
{open && selectables.length > 0 ? (
<div
className={cn(
"absolute w-full z-10 top-0 rounded-md border bg-popover text-popover-foreground shadow-md outline-none animate-in",
)}
> |
Appreciate the contribution, @adaptive-shield-matrix! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Nice component! Shadcn and radix are pretty great and thanks for putting this out there.
As an FYI for using within a
Dialog
component; in order to make this component functional I had to create aPopover
component that wasn't wrapped in aPopoverPrimitive.Portal
. When used in the context of within aDialog
- I was unable to interact with anything within thePopover
(I was able to focus the Group Items after addingpointer-events-auto
- but for reasons I'm not sure on - I could not get focus to theCommandInput
except after closing the Edit Dialog).This is of course a better issue for the
shadcn
repo (possibly exposing a variant ofPopoverContent
component); but thought I'd leave a note here in case anyone tries to use your component within aDialog
Thanks again!
The text was updated successfully, but these errors were encountered: