From e345ace9e7de8998a877d3dfccaed76b0ca7107a Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 3 Nov 2023 18:25:42 -0400 Subject: [PATCH 1/3] [ci] Fix spelling --- src/main/java/org/apache/ibatis/jdbc/ScriptRunner.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/apache/ibatis/jdbc/ScriptRunner.java b/src/main/java/org/apache/ibatis/jdbc/ScriptRunner.java index 092b30aaa31..0293b35c242 100644 --- a/src/main/java/org/apache/ibatis/jdbc/ScriptRunner.java +++ b/src/main/java/org/apache/ibatis/jdbc/ScriptRunner.java @@ -248,7 +248,7 @@ private void executeStatement(String command) throws SQLException { } try { boolean hasResults = statement.execute(sql); - // DO NOT try to 'imporove' the condition even if IDE tells you to! + // DO NOT try to 'improve' the condition even if IDE tells you to! // It's important that getUpdateCount() is called here. while (!(!hasResults && statement.getUpdateCount() == -1)) { checkWarnings(statement); From 05de14a0cd32ea3bbf349745a285b1f519a1c2e4 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 3 Nov 2023 18:26:06 -0400 Subject: [PATCH 2/3] [pom] Remove allowed jdks from pom as set in parent now initially needed when parent was not released for a while, all up to date now. --- pom.xml | 2 -- 1 file changed, 2 deletions(-) diff --git a/pom.xml b/pom.xml index f2fc1194242..4c696b19eb3 100644 --- a/pom.xml +++ b/pom.xml @@ -154,8 +154,6 @@ 1698763635 - - [11,12),[17,18),[21,22),[22,23) From 92a3a2ceb2735e77d2f9833288215aebf592e530 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 3 Nov 2023 18:33:58 -0400 Subject: [PATCH 3/3] [GHA] Rework ci to use temurin for ea jdks to reduce steps --- .github/workflows/ci.yaml | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index f27e3068693..c8922c313cb 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -7,27 +7,20 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - os: [ubuntu-latest, macOS-latest, windows-latest] - java: [11, 17, 21, 22] - distribution: ['zulu'] + os: [ubuntu-latest, macos-latest, windows-latest] + java: [11, 17, 21, 22-ea] + distribution: ['temurin'] fail-fast: false max-parallel: 4 name: Test JDK ${{ matrix.java }}, ${{ matrix.os }} steps: - uses: actions/checkout@v4 - - name: Set JDK from jdk.java.net - uses: oracle-actions/setup-java@v1 - with: - website: jdk.java.net - release: ${{ matrix.java }} - if: ${{ matrix.java != '11' && matrix.java != '17' }} - - name: Set up older JDK + - name: Set up JDK uses: actions/setup-java@v3 with: java-version: ${{ matrix.java }} distribution: ${{ matrix.distribution }} - if: ${{ matrix.java == '11' || matrix.java == '17' }} - name: Print JDK Version run: java -version - name: Cache local Maven m2