Handle the case when nonce is a base64 string for signMessage #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Original issue:
Currently the
nonce
is being passed as a string of ASCII characters characters fromwallet-selector
in case thenonce
Buffer contains any value greater than128
it adds these symbols to the URL which results in strange behavior such as errors either like:Array length 60 does not match schema length 32 at value.nonce
OR
Changes description
This PR adds the possibility to handle the case when the nonce is passed to the URL as a
base64
string which is more URL-safe but still keeps the old functionality to avoid breaking changes for the current and older versions of thewallet-selector
Changes made to wallet-selector to fix the issue: near/wallet-selector#1067
Preview
Demo