Stripe prices #8424
Merged
Stripe prices #8424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
force-pushed
the
stripe-prices-refactor
branch
from
479c599
to
3604552
Compare
gbp
force-pushed
the
stripe-prices-refactor
branch
from
3604552
to
d1e9029
Compare
gbp
force-pushed
the
stripe-prices-refactor
branch
from
d1e9029
to
a030c3c
Compare
|
@dracos it has been suggested that you might be the best places to review this. There are a lot of additional changes in the linked PRs which really someone should review but not sure if you've really got time to do that? |
|
Sure, I can take a look at them all |
dracos
reviewed
Nov 8, 2024
gbp
force-pushed
the
stripe-prices-refactor
branch
3 times, most recently
from
7ada4b3
to
0994a53
Compare
|
After running the final tests on the staging environment, I discovered this required some minor changes to the migration rake task. I have pushed a fixup to address the issue. Apart from this, everything appears to be in order. |
Using Prices provides more flexibility and will allow us to change the which prices are used on both current and future subscriptions.
Run via: `rails subscriptions:migrate_price OLD_PRICE=pro NEW_PRICE=price_123`
gbp
force-pushed
the
stripe-prices-refactor
branch
from
0994a53
to
d3f4625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
https://github.com/mysociety/whatdotheyknow-private/issues/328
Depends on #8405
Depends on #8407
What does this do?
Switches from Stripe Plans to Prices allowing us to change subscriptions and update Pro our pricing model.