Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SideBySide.ConnectSync.ConnectTimeout under Travis CI #100

Closed
bgrainger opened this issue Oct 12, 2016 · 2 comments
Closed

Fix SideBySide.ConnectSync.ConnectTimeout under Travis CI #100

bgrainger opened this issue Oct 12, 2016 · 2 comments

Comments

@bgrainger
Copy link
Member

The SideBySide.ConnectSync.ConnectTimeout test frequently takes longer than its allowed 3500ms, causing the build to fail. It is almost always fixed by rerunning the build on Travis CI (but external contributors can't force that).

Investigate whether this actually indicates a real problem and how to fix it.

@caleblloyd
Copy link
Contributor

Synchronous connections commonly wait for a thread due to #62 when the system is under load.

Synchronous Connect still calls ConnectAsync().GetAwaiter().GetResult() on .NET core because there is no synchronous connect method. A couple workarounds come to mind:

@caleblloyd
Copy link
Contributor

Haven't seen this in a while, going to close. If we hit again, let's up MinThreads above to 16 and see if that fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants