Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] 432Hz Batch Converter - show more decimal places when calculating the source pitch #36

Open
NintendoManiac64 opened this issue Feb 10, 2024 · 0 comments

Comments

@NintendoManiac64
Copy link

NintendoManiac64 commented Feb 10, 2024

As of at least v3.3, only a single decimal place is shown when calculating the source pitch, e.g. 440.3 or the like.

My suggestion is simple then—show more decimal places! Ideally I'd like to see at least 3 decimal places assuming that the value is being rounded to the nearest, otherwise 4 decimal places would be better it it's not rounding the displayed pitch value to the nearest (but even 2 decimal places would be much better than the current one decimal place).

 
The gist is that sometimes you need to know the percentage change in song length when using the "skip tempo adjustment for quality" setting, mainly for games and visual novels that have secondary metadata specifying which samples are where a given song is supposed to loop, and showing more decimal places for the source pitch lets you correctly calculate what the proper samples for looping and the like should be.

Additionally there are times where you can't even re-encode the source audio whether due to concerns over lossy--to-▶lossy transcoding or because it's some proprietary ADPCM format, in which case you next best option is to instead change the playback sample rate directly. This however requires you to know what the destination sample rate should be for a given piece of audio, and displaying more decimal points for the source pitch detection would allow you to accurately calculate what sample rate you should use.

 
Currently the only way to calculate the correct values for either scenario is to use a different program, such as foobar2000 or Audacity, and divide the total amount of samples your source has by the total amount of samples in the converted output and then take that total and multiply it by the original sample point for looping (1st scenario) or by the original sample rate (2nd scenario).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant