Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint 8.x #14

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MichaelDeBoey
Copy link

@MichaelDeBoey MichaelDeBoey commented Aug 22, 2021

@MichaelDeBoey
Copy link
Author

MichaelDeBoey commented Aug 22, 2021

Tests are failing

> eslint4b@8.0.0-beta.0 pretest
> node scripts/build

[20:56:06] Remove 'dist'.
[20:56:06] Update 'scripts/shim/core-rules.js'.
[20:56:06] Parse the source files.
'eslint' is imported by scripts/shim/linter.js, but could not be resolved – treating it as an external dependency
'eslint' is imported by scripts/shim/index.js, but could not be resolved – treating it as an external dependency
[20:56:06] Generate file contents.
Entry module "scripts/shim/linter.js" is implicitly using "default" export mode, which means for CommonJS output that its default export is assigned to "module.exports". For many tools, such CommonJS output will not be interchangeable with the original ES module. If this is intended, explicitly set "output.exports" to either "auto" or "default", otherwise you might want to consider changing the signature of "scripts/shim/linter.js" to use named exports only.
Entry module "scripts/shim/core-rules.js" is implicitly using "default" export mode, which means for CommonJS output that its default export is assigned to "module.exports". For many tools, such CommonJS output will not be interchangeable with the original ES module. If this is intended, explicitly set "output.exports" to either "auto" or "default", otherwise you might want to consider changing the signature of "scripts/shim/core-rules.js" to use named exports only.
Entry module "scripts/shim/index.js" is implicitly using "default" export mode, which means for CommonJS output that its default export is assigned to "module.exports". For many tools, such CommonJS output will not be interchangeable with the original ES module. If this is intended, explicitly set "output.exports" to either "auto" or "default", otherwise you might want to consider changing the signature of "scripts/shim/index.js" to use named exports only.
[20:56:06] Minify file contents.
[20:56:06] - linter.js
[20:56:06] - core-rules.js
[20:56:07] - index.js
[20:56:07] Check version.
[20:56:07] Up to date: 8.0.0-beta.0
[20:56:07] Completed!

> eslint4b@8.0.0-beta.0 test
> npm run -s lint && karma start --single-run


Oops! Something went wrong! :(

ESLint: 8.0.0-beta.0

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Failed to load plugin '@mysticatea' declared in '.eslintrc.yml': Package subpath './lib/rules/array-bracket-spacing' is not defined by "exports" in .../eslint4b/node_modules/eslint/package.json
Referenced from: .../eslint4b/.eslintrc.yml
    at new NodeError (node:internal/errors:370:5)
    at throwExportsNotFound (node:internal/modules/esm/resolve:335:9)
    at packageExportsResolve (node:internal/modules/esm/resolve:560:3)
    at resolveExports (node:internal/modules/cjs/loader:476:36)
    at Function.Module._findPath (node:internal/modules/cjs/loader:516:31)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:913:27)
    at Function.Module._load (node:internal/modules/cjs/loader:772:27)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (.../eslint4b/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at Object.<anonymous> (.../eslint4b/node_modules/eslint-plugin-vue/lib/rules/array-bracket-spacing.js:10:3)

This will be fixed by merging mysticatea/eslint-plugin#29, as that loosens the version of eslint-plugin-vue.

@MichaelDeBoey MichaelDeBoey marked this pull request as draft August 22, 2021 19:01
@MichaelDeBoey MichaelDeBoey changed the title Support ESLint 8.x feat: support ESLint 8.x Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 8.x
1 participant