Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using asyncio #11

Open
mystor opened this issue Aug 31, 2018 · 0 comments
Open

Consider using asyncio #11

mystor opened this issue Aug 31, 2018 · 0 comments

Comments

@mystor
Copy link
Owner

mystor commented Aug 31, 2018

The vast majority of phlay's runtime is spent doing network I/O or calling expensive subprocesses. If we switch to using asyncio instead, we can start running these processes in parallel, which might make it run faster.

The primary motivator for this is git-cinnabar, which takes a while to perform the git->hg conversions required to get the mercurial sha1s. As this is a fairly reliable process, and shouldn't affect whether or not the user would want to push their commits, it would be nice to start it early in the process, but not block on its completion until after the user types 'y'.

There are also a series of conduit queries which are somewhat slow and might be nice to parallelize.

Fortunately, as we depend on python >= 3.6, we have access to asyncio, which should make this much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant