Updated datfile format and new Legolas header #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-claes
added
legolas-backend
n-claes
force-pushed
the
refactor/datfile_update
branch
2 times, most recently
from
d6c2d1a to
f43f24b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #116 +/- ##
============================================
+ Coverage 78.39% 90.49% +12.09%
============================================
Files 132 146 +14
Lines 7022 8456 +1434
============================================
+ Hits 5505 7652 +2147
+ Misses 1517 804 -713
Flags with carried forward coverage won't be shown. Click here to find out more. |
n-claes
force-pushed
the
refactor/datfile_update
branch
2 times, most recently
from
5c95465 to
ec2a791
Compare
n-claes
force-pushed
the
refactor/datfile_update
branch
from
ec2a791 to
81bc829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The third PR in the Legolas 2.0 preparation series, based on #114 and #115 so they should go in first (in that order).
This updates the datfile format and writes a lot more information to the header following all the new features that have been added. The "old" header is now legacy and replaced by the new format, the entire Pylbo framework is still fully backwards compatible with older files.
The most important additions to the header are the block dimensions, physics type, solver settings and accounted physics, which will be needed for the upcoming subsystem support.
New features
Legolas
Pylbo
TODO