-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor background equilibrium into dedicated functions #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-claes
added
legolas-backend
Under-the-hood changes to Legolas
performance
Affects performance
refactor
Refactoring existing code
legolas-api
Changes to the Legolas user API
labels
Mar 29, 2023
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
legolas-api
Changes to the Legolas user API
legolas-backend
Under-the-hood changes to Legolas
performance
Affects performance
refactor
Refactoring existing code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR deprecates the various equilibrium fields (
rho_field
,T_field
,v_field
andB_field
) and favours dedicated functions to specify the background. A newbackground
object is created with various instances containing pointers to the equilibrium functions, which can be subsequently called.Note that this PR breaks the Legolas API in the user submodule. This change implies:
intent(in)
statements prevent unwanted changes in the background state.x
. This means that we no longer have to interpolate between the base grid, Gaussian grid or eigenfunction grid (eg. for derived eigenfunctions).Before
After this PR
New features
Legolas
background
object to govern the equilibrium background state