Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes and edits related to 2.0 #132

Merged
merged 7 commits into from
Apr 17, 2023
Merged

Conversation

n-claes
Copy link
Owner

@n-claes n-claes commented Apr 14, 2023

PR description

Various minor changes and edits to the source code related to the 2.0 release.

Overview

Legolas

  • changed the io and solver settings objects type names to be more consistent
  • renamed duplicate physics_t type, the one from settings is now called physics_settings_t
  • made radial derivative of para/perp thermal conduction into type-bound procedures instead of pointers
  • logging of equilibrium inspections now occurs after initialisations

Bugfixes

Pylbo

@n-claes n-claes added bug Something isn't working legolas-backend Under-the-hood changes to Legolas pylbo Affects the post-processing framework Pylbo labels Apr 14, 2023
@n-claes n-claes added this to the Legolas 2.0 milestone Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #132 (7d56f32) into develop (cb16927) will increase coverage by 0.05%.
The diff coverage is 91.12%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #132      +/-   ##
===========================================
+ Coverage    90.54%   90.60%   +0.05%     
===========================================
  Files          158      158              
  Lines         8949     8970      +21     
===========================================
+ Hits          8103     8127      +24     
+ Misses         846      843       -3     
Flag Coverage Δ
legolas 93.03% <90.55%> (+0.06%) ⬆️
pylbo 86.13% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@n-claes n-claes merged commit b4b72a5 into develop Apr 17, 2023
@n-claes n-claes deleted the misc/tweaks_and_edits branch April 17, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working legolas-backend Under-the-hood changes to Legolas pylbo Affects the post-processing framework Pylbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant