Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylbo: better handling of balance equations #142

Merged
merged 8 commits into from
May 11, 2023

Conversation

n-claes
Copy link
Owner

@n-claes n-claes commented May 11, 2023

PR description

This PR improves the way Pylbo handles the equilibrium balance equations. The derivatives of thermal conductions are added to the datfile in a backwards compatible way to make sure the energy balance is calculated correctly.
Plotting the balance is now interactive, similar to how the background is treated using a clickable legend.
The legend entries for the background plot are now properly latexified as well.

New features

Legolas

  • Derivatives of thermal conduction are added to the datfile
  • New method pylbo.get_equilibrium_balance(ds), which returns a dict containing the equilibrium balance equations

Pylbo

  • Equilibrium balance plot is now interactive

@n-claes n-claes added feature Implementation of a new feature pylbo-backend Under-the-hood changes to Pylbo labels May 11, 2023
@n-claes n-claes added this to the Legolas 2.1 milestone May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #142 (f93d827) into develop (8f67a2a) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #142      +/-   ##
===========================================
+ Coverage    90.68%   90.79%   +0.10%     
===========================================
  Files          158      159       +1     
  Lines         8977     9048      +71     
===========================================
+ Hits          8141     8215      +74     
+ Misses         836      833       -3     
Flag Coverage Δ
legolas 93.11% <100.00%> (+<0.01%) ⬆️
pylbo 86.70% <100.00%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@n-claes n-claes merged commit 71f15ec into develop May 11, 2023
@n-claes n-claes deleted the feature/plot_full_eq_balance branch May 11, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implementation of a new feature pylbo-backend Under-the-hood changes to Pylbo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant