QoL: better logging for user-defined heating #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #143 +/- ##
===========================================
- Coverage 90.79% 90.78% -0.01%
===========================================
Files 159 159
Lines 9048 9050 +2
===========================================
+ Hits 8215 8216 +1
- Misses 833 834 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
n-claes
force-pushed
the
qol/usr_H_warning
branch
from
acd1798 to
0c3cb73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Minor Quality-of-Life update, Legolas now throws a proper warning if a user-defined heating function is provided while forced thermal balance is enabled. This is done right before the equilibrium balance equations are checked, after info is logged to the console.