-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework matrix assembly + Hall/viscosity/v01/B01 extensions #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-claes
added
feature
Implementation of a new feature
legolas-backend
Under-the-hood changes to Legolas
refactor
Refactoring existing code
tests-unit
Modified or new unit tests
labels
May 27, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Implementation of a new feature
legolas-backend
Under-the-hood changes to Legolas
refactor
Refactoring existing code
tests-unit
Modified or new unit tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR includes a complete overhaul of the way the matrices are assembled. Every physical effect has been split off in its own dedicated submodule which handles matrix assembly only for those particular physics. Addition of these effects to the "main" matrices now depends on which physics are included instead of adding all zeroes. The boundaries are treated in a similar way, with a dedicated submodule for each physical part of the essential/natural boundary conditions.
This also adds two new physical effects to the code: viscosity and Hall MHD. The "allowed" equilibrium is also extended, since we can now have a non-zero v01 component allowing for compressible background flows on top of a non-zero (constant) B01 field allowing for magnetic fields aligned with the direction of inhomogeneity.
Regression tests + the way eigenfunctions are handled in the testing framework have been improved as well.
New features
Note: viscosity, v01 and B01 have been roughly checked and should work for the most part. We still have to add tests for these, but we can do that in a different PR (otherwise this one would get really big). Hall does NOT yet work properly, so for the moment warnings are printed whenever Hall/viscosity is enabled.