Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved CI, code coverage and test extensions #70

Merged
merged 42 commits into from
Jul 8, 2021
Merged

Improved CI, code coverage and test extensions #70

merged 42 commits into from
Jul 8, 2021

Conversation

n-claes
Copy link
Owner

@n-claes n-claes commented Jun 15, 2021 •
edited
Loading

This is a work in progress, I'm already opening the PR to make sure the coverage options in the .yml file are correct and to trigger the codecov activation.

TODO:

  • set up code coverage (cfr. issue CI code coverage #58)
  • make sure coverage reports of unit tests and regression tests are merged
  • extend testing framework with viscosity tests
  • extend testing framework with Hall tests <-- still work in progress, do in different PR
  • update unit tests
  • extend unit tests
  • re-enable multirun regression tests

@n-claes n-claes added the tests-unit Modified or new unit tests label Jun 15, 2021
@n-claes n-claes self-assigned this Jun 15, 2021
@n-claes n-claes force-pushed the tests/improved_testing branch from 6d9d7e9 to a556854 Compare June 15, 2021 13:49
@n-claes n-claes marked this pull request as draft June 15, 2021 13:49
@n-claes n-claes force-pushed the tests/improved_testing branch 5 times, most recently from 9224a0a to 7bf53d3 Compare June 15, 2021 15:17
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@29ed6fc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #70   +/-   ##
==========================================
  Coverage           ?   85.74%           
==========================================
  Files              ?       79           
  Lines              ?     3754           
  Branches           ?        0           
==========================================
  Hits               ?     3219           
  Misses             ?      535           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ed6fc...d21859c. Read the comment docs.

@n-claes n-claes added this to the v1.1 milestone Jun 23, 2021
@n-claes n-claes marked this pull request as ready for review July 6, 2021 08:12
n-claes added 18 commits July 7, 2021 11:43
@n-claes
updated CI workflow, added code coverage
2666961
@n-claes
enable coverage in regression tests
f85a713
@n-claes
minor unit tests edits for readability
fd3d0a1
@n-claes
improved grid-related unit tests
61e3d00
@n-claes
removed mesh accumulation in favour of custom_grid
93a06ac
@n-claes
improved testing of input module
f6efbf2
@n-claes
simplification and updates of mod_check_values
d191bb4
@n-claes
fix fluxtube regression tests after removal of mesh accumulation
c600f92
@n-claes
improved testing of value checks
cabcd32
@n-claes
minor modifications to testing of units
c93891a
@n-claes
use inferred size for rosner cooling + test updates
b1e0a6c
@n-claes
minor unit test updates
42d057b
@n-claes
rework of thermal conduction unit tests
6e2a60d
@n-claes
disable unittests in progress in cmakelists
83af765
@n-claes
updated boundary unit tests, added viscosity
54af3f1
@n-claes
spline and subblock unit tests
a0b5c67
@n-claes
extended matrix operation unit tests
6da7319
@n-claes
updated interpolation unit tests
ef438e0
n-claes added 24 commits July 7, 2021 11:43
@n-claes
updated integration unit tests
e84c4c4
@n-claes
use procedures for solvers in submodules
8ecda76
@n-claes
extended lapack solver unit tests
ded7a4b
@n-claes
extended arpack unit tests
4723f99
@n-claes
switch from gcovr to lcov for coverage report
4bb03d1
@n-claes
added geometry_override unit tests
3e9baff
@n-claes
added unit tests for inspections
89a7ec9
@n-claes
modify exclusion flags for lcov
10c4343
@n-claes
logging unit tests + bugfix str complex function
423e20c
@n-claes
added unit tests for matrix operators
c8d1299
@n-claes
unit tests for cooling curves
1b495f9
@n-claes
exclude equilibria defaults from coverage + formatting
f5afcbb
@n-claes
added is_constant method to available checks
63fea8e
@n-claes
minor bugfixes in solar atmosphere module
5770139
@n-claes
added unit tests for solar atmosphere module
7f0a802
@n-claes
added regression test for couette flow
2a30822
@n-claes
fix directory issue in yml script
1f080f0
@n-claes
regression test for taylor_couette added
43650d7
@n-claes
exclude user file from code coverage
c1cf85d
@n-claes
improved testing of multiruns
aec2099
@n-claes
remove untested warning from gravito mhd modules
0d25d46
@n-claes
add regression tests for nye-thomas atmosphere
ebbe0dc
@n-claes
remove baseline images (no longer used)
e1f5c70
@n-claes
re-enable pylbo tests
515d366
@n-claes n-claes force-pushed the tests/improved_testing branch from d21859c to 515d366 Compare July 8, 2021 07:45
@n-claes n-claes merged commit 3c70a4f into develop Jul 8, 2021
@n-claes n-claes deleted the tests/improved_testing branch July 12, 2021 09:53
@n-claes n-claes mentioned this pull request Jul 16, 2021
Merged
@n-claes n-claes linked an issue Jul 16, 2021 that may be closed by this pull request
CI code coverage #58
Closed
@n-claes n-claes mentioned this pull request Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@n-claes n-claes

Labels
tests-unit Modified or new unit tests
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

CI code coverage
2 participants
@n-claes @codecov-commenter