-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature: eigenfunction subset #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-claes
added
feature
Implementation of a new feature
legolas-backend
Under-the-hood changes to Legolas
refactor
Refactoring existing code
labels
Aug 13, 2021
Codecov Report
@@ Coverage Diff @@
## develop #75 +/- ##
===========================================
+ Coverage 81.46% 86.88% +5.41%
===========================================
Files 99 102 +3
Lines 5876 5885 +9
===========================================
+ Hits 4787 5113 +326
+ Misses 1089 772 -317
Flags with carried forward coverage won't be shown. Click here to find out more. |
n-claes
force-pushed
the
feature/eigenfunc_selection
branch
from
August 17, 2021 08:38
3f6bd9d
to
e227766
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Implementation of a new feature
legolas-backend
Under-the-hood changes to Legolas
refactor
Refactoring existing code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR adds the possibility to select which eigenfunctions need to be saved to the datfile. Previously all eigenfunctions were automatically saved, including the ones from modes that were far from resolved. This is a needless waste of datfile storage since those eigenfunctions will never be used.
Here we add some flags to the savelist namelist, where one can now provide a point in the complex plane and draw a circle around it, and only the eigenvalues inside that circle will have their eigenfunctions saved.
This PR does a complete overhaul of how eigenfunctions are treated (both for the base eigenfunctions as derived quantities thereof). Base eigenfunctions and derived quantities are now split up into submodules, eigenfunction assembly has been simplified.
TODO code
"postprocessed" -> "derived_eigenfunctions"
? confusion with directory "post_processing" already present... Also, these are derived quantities and calculated on-the-fly along with the regular eigenfunctions and not during postprocessing.TODO tests