Pylbo: improved subplot addition #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-claes
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #77 +/- ##
===========================================
+ Coverage 86.88% 87.00% +0.11%
===========================================
Files 102 102
Lines 5885 5885
===========================================
+ Hits 5113 5120 +7
+ Misses 772 765 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Improves the
_add_subplot_axesmethod in the FigureManager to be compatible with more complex subplot layouts, also fixes the deprecationwarning forchange_geometryfrom matplotlib 3.4 onwards. Closes #76.Also fixes the "packaging" dependency issue in the
setup.pyinstallation file.