Hall by momentum equation substitution #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #88 +/- ##
===========================================
+ Coverage 87.01% 88.47% +1.45%
===========================================
Files 102 102
Lines 5922 5960 +38
===========================================
+ Hits 5153 5273 +120
+ Misses 769 687 -82
Flags with carried forward coverage won't be shown. Click here to find out more. |
n-claes
added
legolas-backend
n-claes
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Implementation of the Hall feature changed to a different set of equations, using a substitution of JxB using the momentum equation. The electron pressure term is handled by introducing the
electron_fraction.Bugfixes
Legolas
boundary_type = "wall_weak"added.