Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console/cli is missing listing the contents of a collection #2658

Open
divagant-martian opened this issue Aug 21, 2024 · 3 comments
Open

console/cli is missing listing the contents of a collection #2658

divagant-martian opened this issue Aug 21, 2024 · 3 comments
Assignees
Labels
c-iroh-cli feat New feature or request

Comments

@divagant-martian
Copy link
Contributor

divagant-martian commented Aug 21, 2024

the blobs::Client has pub async fn get_collection(&self, hash: Hash) -> Result<Collection> for which there is no matching counterpart in the cli/console.

The Collection type has a lot of manipulation methods we probably do not want to map. However, a blobs collection <hash> which lists the blobs (by calling pub fn iter(&self) -> impl Iterator<Item = &(String, Hash)>) I think is both useful enough, and close enough to the rust api to be a good match to this top level client function

@dignifiedquire dignifiedquire added feat New feature or request c-iroh-cli labels Aug 22, 2024
@palozano
Copy link
Contributor

@divagant-martian, is this an issue I could take?

@divagant-martian
Copy link
Contributor Author

@dignifiedquire @b5 do you guys think we should add this api to the cli? @palozano is already familiar with the cli code so this could be easy for him to do

@dignifiedquire
Copy link
Contributor

sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-iroh-cli feat New feature or request
Projects
Status: No status
Development

No branches or pull requests

3 participants