Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry v8 compatible integration #2193

Open
gajus opened this issue Mar 22, 2024 · 7 comments
Open

Add Sentry v8 compatible integration #2193

gajus opened this issue Mar 22, 2024 · 7 comments
Labels
kind/bug Something isn't working stage/0-issue-prerequisites Needs more information before we can start working on it

Comments

@gajus
Copy link

gajus commented Mar 22, 2024

Just flagging that the current plugins are not compatible with Sentry v8 SDK.

Some related context:

@EmrysMyrddin EmrysMyrddin added kind/bug Something isn't working stage/0-issue-prerequisites Needs more information before we can start working on it labels Mar 22, 2024
@akabekobeko
Copy link

It looks like need to migrate from startTransaction to startSpan, which was deprecated in Sentry v8.

ERR TypeError: Sentry.startTransaction is not a function
      at onExecute (.../node_modules/@envelop/sentry/cjs/index.js:48:35)
      at .../node_modules/graphql-yoga/node_modules/@envelop/core/cjs/orchestrator.js:360:37

@bgentry
Copy link

bgentry commented Jul 15, 2024

Related dep upgrade PR #2235

Needs some manual work to get it over the line and adjust to the new APIs.

@trixobird
Copy link
Contributor

trixobird commented Aug 4, 2024

jsut created a new PR #2277, with all the tests passing. I did add a @ts-expect-error though :'(

@bastiankistner
Copy link

@trixobird wonderful! Was just looking for this 👏

@trixobird
Copy link
Contributor

trixobird commented Aug 8, 2024

@benjie, @n1ru4l is there anything else needs from my side to get this PR reviewed and hopefully merged? Apologies for the newbie question

@klippx
Copy link
Contributor

klippx commented Oct 2, 2024

@trixobird you should probably update the change-set to major since you are removing support for old sentry versions.

@trixobird
Copy link
Contributor

@klippx done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working stage/0-issue-prerequisites Needs more information before we can start working on it
Projects
None yet
Development

No branches or pull requests

7 participants