Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App stalls/hangs #246

Open
HarrievG opened this issue Nov 11, 2024 · 8 comments
Open

App stalls/hangs #246

HarrievG opened this issue Nov 11, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@HarrievG
Copy link

HarrievG commented Nov 11, 2024

Running latest edge
Version 130.0.2849.80 (Official build) (64-bit)
and latest page-assist
Version: 1 . 3 . 3

This has been an issue from the start.
Every couple of seconds it hangs for a second. No other webpage or app/extension in the edge browser is doing this.

After inspecting the logs it seems to coincide with the /api/tags update.

2024/11/11 - 13:29:28 | 200 | 2.6771ms | 127.0.0.1 | GET "/api/tags"
2024/11/11 - 13:29:50 | 200 | 2.2569ms | 127.0.0.1 | GET "/api/tags"
2024/11/11 - 13:30:14 | 200 | 3.7969ms | 127.0.0.1 | GET "/api/tags"
2024/11/11 - 13:30:38 | 200 | 2.4413ms | 127.0.0.1 | GET "/api/tags"
2024/11/11 - 13:31:02 | 200 | 2.8498ms | 127.0.0.1 | GET "/api/tags"
2024/11/11 - 13:31:24 | 200 | 2.8495ms | 127.0.0.1 | GET "/api/tags"
2024/11/11 - 13:31:48 | 200 | 2.8618ms | 127.0.0.1 | GET "/api/tags"
2024/11/11 - 13:32:12 | 200 | 2.0998ms | 127.0.0.1 | GET "/api/tags"

Why are these polls actually needed every 23 sec? Its even polling while you are not using the model dropdown or even when the browser tab is not active?

The stall is disruptive and annoying.

Let me know if you need any more info to pinpoint and solve this.

@n4ze3m n4ze3m added the bug Something isn't working label Nov 11, 2024
@n4ze3m
Copy link
Owner

n4ze3m commented Nov 11, 2024

Hey, sorry about the issue. I added it in the first version without knowing it would cause problems. I'll remove it in the upcoming update (1.3.5) this weekend.

@HarrievG
Copy link
Author

After update I will confirm and close bug right away.

Thanks a lot!

@n4ze3m n4ze3m mentioned this issue Nov 16, 2024
@HarrievG
Copy link
Author

This has gotten worse since I added 2 new models, it is totally unusable now. :"(

I tried to profile it to get some impression where this is actually coming from.
In a 17 second trace made with the devtools in Edge, there is a total of 8 seconds of "Minor GC" .

This trace was captured without ollama running, so im not sure if this is all going to be solved by your change in ollama.ts.

When are you going to release 1.3.5? Do you have any idea what is causing this?

@n4ze3m
Copy link
Owner

n4ze3m commented Nov 20, 2024

Needs a few more tests before release. It's currently in draft but will be ready soon. :)

@HarrievG
Copy link
Author

I just tried again, and unfortunately it did not help.
While cleaning up i deleted all knowledge, and suddenly it become responsive again. so it might be something in regards to that.

@n4ze3m
Copy link
Owner

n4ze3m commented Nov 28, 2024

Yeah, that might be the issue since we are saving files, chunks, and embeddings, which could cause problems. Also, how many knowledge bases did you have when this issue occurred?

@n4ze3m n4ze3m mentioned this issue Dec 14, 2024
@HarrievG
Copy link
Author

HarrievG commented Dec 15, 2024

Around 5, not super big in size, mostly pdf collections of source code.
I keep an eye out on it and when I hit it again, ill reply here.

@n4ze3m
Copy link
Owner

n4ze3m commented Dec 16, 2024

Version 1.3.8 is waiting for approval on the Chrome Web Store. It may take 2–3 days to get approved. Version 1.3.8 includes a fix to stop tracking fully processed files from the knowledge base, which helps reduce size and prevent hangs as the storage grows. I'll let you know once it is released on Chrome. It is currently available on Firefox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants